[Nagiosplug-devel] how do I get a patch integrated

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 26/05/09 01:11 PM, Matthias Eble wrote:
> Am Dienstag, den 26.05.2009, 16:43 +0100 schrieb Alain Williams: 
>> About a week ago I put up a patch for the check_procs plugin, I have not
>> seen any comment about it. How can I help it to be made part of the released version ?
>>
>> You can view a description of it here:
>>
>> 	http://sourceforge.net/tracker/?func=detail&aid=2794120&group_id=29880&atid=397599
>>
> 
> Hi Alain,
> 
> I had a short look at it and I somewhat disliked the fact that it makes
> use of a temp file. Even though this looks absolutely arguable for your
> enhancement, we usually avoid temporary files:
> http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN254 
> 
> Submitting patches to the tracker and ringing the bells on np-devel if
> nothing happens is the right approach.
> 
> Detecting a CPU hog would be a nice thing, though. Other opinions?

I agree - I do not like temp files either. For small stuff I like to use
performance data string (I have a perl plugin implementing that, and a
outdated branch tries to implement that with check_snmp).

For bigger stuff, would shared memory segments be a good substitute for
temp files?

Regarding this patch, it is quite invasive... so much I'm wondering if
it wouldn't be better as a separate plugin. One thing I would have liked
too is a plugin parsing SAR logfiles (which would allow getting many
more metrics), unfortunately sar does not seem to log anything that
would help finding cpu hogs (there's pidstat but even with the latest
release of sysstat I couldn't find a way to get that info logged to
file). If we could get sar to log pidstat info we could get a *very*
useful general-purpose plug-in by parsing the sar log file.

- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKHHwh6dZ+Kt5BchYRAtf0AKCwkhyUSC7R2N6YjoKbNQgN9d59qACbBdrf
wLKk7VWAGW6w/3VZ+iVFnTE=
=BP0D
-----END PGP SIGNATURE-----