[Nagiosplug-devel] how do I get a patch integrated

[Alain Williams]

On Tue, May 26, 2009 at 07:11:18PM +0200, Matthias Eble wrote:
> Am Dienstag, den 26.05.2009, 16:43 +0100 schrieb Alain Williams: 
> > About a week ago I put up a patch for the check_procs plugin, I have not
> > seen any comment about it. How can I help it to be made part of the released version ?
> > 
> > You can view a description of it here:
> > 
> > 	http://sourceforge.net/tracker/?func=detail&aid=2794120&group_id=29880&atid=397599
> > 
> 
> Hi Alain,
> 
> I had a short look at it and I somewhat disliked the fact that it makes
> use of a temp file. Even though this looks absolutely arguable for your
> enhancement, we usually avoid temporary files:
> http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN254 

I looked at that, I could not see a way round it.

For this to work I need to keep information on 'bad' processes between invocations
of the plugin. I cannot see any other sensible way of holding it; shared memory
would do - but I think is a worse approach.

An improvement would be if Nagios were to export an environment variable (eg NAGIOS_STATE_DIR)
where such state files could be kept -- but that is not today's nagios.

> Submitting patches to the tracker and ringing the bells on np-devel if
> nothing happens is the right approach.

Thanks

> Detecting a CPU hog would be a nice thing, though. Other opinions?

Done at the request of a customer, it seems to work well on his machine.

-- 
Alain Williams
Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT Lecturer.
+44 (0) 787 668 0256  http://www.phcomp.co.uk/
Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php
Past chairman of UKUUG: http://www.ukuug.org/
#include <std_disclaimer.h>