[Nagiosplug-devel] Enhancement Patch for check_icmp

[Thomas Guyot-Sionnest]

> -----Original Message-----
> From: nagiosplug-devel-bounces at lists.sourceforge.net 
> [mailto:nagiosplug-devel-bounces at lists.sourceforge.net] On 
> Behalf Of Marlo Bell
> Sent: March 7, 2007 11:45
> To: nagiosplug-devel at lists.sourceforge.net
> Subject: [Nagiosplug-devel] Enhancement Patch for check_icmp
> 
> We had a need to use check_icmp to check redundant links and 
> report back on the total availability (end-user perspective). 
> Thus if one of the links was up, we needed the plugin to return an OK.
>  
> To do this our now defunct developer (he left for another 
> job) altered check_icmp to allow us to specify (-m) the 
> minimum number of hosts which must return ok to report an OK 
> to nagios.
>  
> I moved the changes into nagios-plugins-1.4.6 and created the 
> diff file and universal patch file. I have attached them-can 
> we get this or a better implementation of this into CVS? Can 
> anyone else benefit from it?

Indeed this is an interesting feature. I'll rework it a bit and commit it
into CVS shortly.

What I will change:

1. minHostsOk will be set to NULL initially
2. minHostsOk data type does not match with strtoul()
3. Return WARNING if at least minHostsOk hosts are in OK or WARNING state.
4. Will possibly add sanity checking
5. Add a testcase

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3076 bytes
Desc: not available
URL: <http://nagios-plugins.org/archive/devel/attachments/20070307/72107eec/attachment.bin>