[Nagiosplug-devel] [nagios-plugins] check_procs: add option to ignore plugin parent process (#1205)

[Anton Löfgren]

This fixes an issue that appears when running check_procs over NRPE,
where the default shell is configured to (for example) dash, as is the
case on Debian.

dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process
to execute the argument string. Contrast this with bash, which does not
do this, provided that the argument string simply can be exec()'d as-is.

To demonstrate:
$ bash -c pstree
init─┬ ..
    ...
	├─sshd─-─sshd───pstree

versus
$ dash -c pstree
init─┬ ..
    ...
	├─sshd─-─sshd───dash───pstree

The consequence of this fork is that the following invokation:
    /opt/plugins/check_procs -a init

will result in this output:

    PROCS OK: 2 processes with args 'init' | processes=2;;;0;

because the check_procs, in addition to finding the actual init process,
finds its parent shell as well.

This example is a bit contrived, but I think it illustrates the
point.

This wouldn't really be a problem, and normally isn't, if it weren't
for the fact that NRPE uses a call to popen() which does exactly the
above (executes '/bin/sh -c ...'), causing inconsistent behaviour
between distributions and much confusion for end users.

The argument may be made that the dash process spawned by NRPE is just a
process like any other, and should therefore be included in the process
count just like any other. However, this is not very intuitive, because
of the previously mentioned inconsistencies.

The argument might also well be made that we're _never_ interested in the
immediate ancestor of the plugin, but it is unknown how many
installations have already made the necessary modifications to their
setups to make up for the fact that the plugin behaves the way it does.

Thus, this patch adds an option --ignore-parent, which could (and
indeed, in my opinion, should) be used, if you want to run check_procs through NRPE,
with the -a option.

See also these bug reports:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913
http://sourceforge.net/p/nagiosplug/bugs/512/
https://github.com/nagios-plugins/nagios-plugins/issues/999
https://bugs.op5.com/view.php?id=4398
You can merge this Pull Request by running:

  git pull https://github.com/catharsis/nagios-plugins issue-999

Or you can view, comment on it, or merge it online at:

  https://github.com/nagios-plugins/nagios-plugins/pull/1205

-- Commit Summary --

  * check_procs: add option to ignore plugin parent process

-- File Changes --

    M plugins/check_procs.c (16)
    M plugins/t/check_procs.t (13)

-- Patch Links --

https://github.com/nagios-plugins/nagios-plugins/pull/1205.patch
https://github.com/nagios-plugins/nagios-plugins/pull/1205.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://nagios-plugins.org/archive/devel/attachments/20131018/0f999e7b/attachment.html>