[Nagiosplug-devel] [ nagiosplug-Bugs-3608135 ] check_smtp -D (1.4.16) doesn't QUIT

[SourceForge.net]

Bugs item #3608135, was opened at 2013-03-15 02:24
Message generated for change (Tracker Item Submitted) made by j-bern
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3608135&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J. Bern (j-bern)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_smtp -D (1.4.16) doesn't QUIT

Initial Comment:
Plugin Version (-V output): 1.4.16
Plugin Name: check_smtp
Plugin Commandline showing issues: check_smtp -H [postfix-MTA-IP] -F nagios.[domain] -S -D 5,2 -v
Operating System: CentOS
Architecture: x86_64
Compiler: (from repos)

check_smtp -D executes the "if ( check_cert )" branch, which calls my_close(), which closes the connection. No SMTP QUIT command is being sent, which makes the (postfix) MTA log "lost connection after EHLO" warning messages. Please include an smtp_quit() somewhere along this code path.

(I'm not submitting a patch myself because I don't know offhand whether the smtp_quit() should go into the "if ( check_cert )" branch alone, or become part of my_close(), which also handles two EHLO error cases.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3608135&group_id=29880