[Nagiosplug-devel] [ nagiosplug-Patches-1407587 ] check_ntp: multi-peer support, don't abort on ntpdate error

[SourceForge.net]

Patches item #1407587, was opened at 2006-01-16 19:57
Message generated for change (Comment added) made by hweiss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1407587&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Joachim Schrod (jschrod)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_ntp: multi-peer support, don't abort on ntpdate error

Initial Comment:
check_ntp currently does not support multiple peers,
when one is not synchronized to the last peer. Then the
jitter value is overwritten with '(not parsed)'. (See
bug #1267741.)

This also causes an annoying warning message. (See bug
#1251096.)

In bug #1251096, harpermann also mentioned that he has
fixed `bad exit status' by ntpdate or ntpq. Version
1.31 of check_ntp.pl now aborts with die if ntpdate or
ntpq have an exit status != 0.
For example, this happens when no ntp server is
running. But then ntpdate works properly and reports
that no server was available. This message is also
parsed by check_ntp and handled correctly. I.e., one
should not abort then, but should use the existing
control flow of the check script.

This patch handles both multi-peer situations, and also
corrects the ntpdate/ntpq exit status check.

In addition, it allows host names (and domain names in
FQDNs) to consist of one char only.

By the way, why has the ntpdate output been removed
from -v? It should better remain in.

----------------------------------------------------------------------

>Comment By: Holger Weiss (hweiss)
Date: 2010-04-13 00:47

Message:
These days, we provide two new plugins (written from scratch in C) instead
of check_ntp.pl, so I guess this report is obsolete.

----------------------------------------------------------------------

Comment By: Joachim Schrod (jschrod)
Date: 2006-01-16 20:21

Message:
Logged In: YES 
user_id=70318

Forgot that: The patch also adds support for unknown hosts.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1407587&group_id=29880