[Nagiosplug-devel] [ nagiosplug-Bugs-2861789 ] memory leak

[SourceForge.net]

Bugs item #2861789, was opened at 2009-09-18 22:21
Message generated for change (Settings changed) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2861789&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: v1.4.14
>Status: Closed
Resolution: Later
Priority: 5
Private: No
Submitted By: Franck Bourdonnec (franck78)
Assigned to: Nobody/Anonymous (nobody)
Summary: memory leak

Initial Comment:
the check_smtp.c plugin have malloc() used (line 144) and no corresponding free()

Should be converted into buffer allocated on stack.


----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2009-10-04 02:21

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2009-09-19 05:27

Message:
If you start tracking every memory allocation leak in nagios plugins you'll
find hundreds (or maybe even thousands) of them. The truth is that plugins
runs for a very short time and it is much faster to let the OS reclaim the
memory on process exit than reclaiming it with free().

OTOH I'm not against it; the difference is not very significant and it
could be useful in the future. For example the plugins code could be loaded
by a daemon instead of running in standalone plugins. It's not the case
right now so this is not a priority.

I'm marking this bug as Pending/Later for now. Feel free to comment if you
think the memory leakage within a single run could be so significant this
is problematic, of if you want to attach an acceptable fix for it.
Otherwise it's just not a priority.

Thanks for reporting bugs against the Nagios Plugins though, this is
always appreciated.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2861789&group_id=29880