[Nagiosplug-devel] [ nagiosplug-Patches-2798295 ] Report expect_string in plugin output if test fails

[SourceForge.net]

Patches item #2798295, was opened at 2009-05-29 04:52
Message generated for change (Comment added) made by dermoth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2798295&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Patricia Jung (patricia_jung)
Assigned to: Nobody/Anonymous (nobody)
Summary: Report expect_string in plugin output if test fails

Initial Comment:
Patch against Plugin Version (-V output): check_http v2053 (nagios-plugins 1.4.13)
Plugin Name: check_http 
Example Plugin Commandline: check_http -H www.trish.de -p 80 -L --onredirect=CRITICAL --string "bla"
Tested on operating system: (SuSE) Linux
Tested on architecture: x86
Tested with compiler: gcc (SUSE Linux) 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036]

With more than one website to monitor one does not want to check the nagios configuration in order to find out the expect string configured. This patch reports it and this way relieves stress in case of failure.

----------------------------------------------------------------------

>Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2009-05-30 09:09

Message:
Thanks for your patch, unfortunately it won't apply to the development head
as there was many changes to check_http since the last release.

Besides, I don't think I could apply this patch as it is right now. Under
some circumstances it could be desired not to show the passed parameters
(sensitive information, very long strings...); an additional parameter
could enable this behaviour. Moreover, this change should also apply to
regex pattern matching (-r)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2798295&group_id=29880