[Nagiosplug-devel] [ nagiosplug-Bugs-1460312 ] check_http doesn't check response time on 300's

[SourceForge.net]

Bugs item #1460312, was opened at 2006-03-28 17:40
Message generated for change (Settings changed) made by dermoth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1460312&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Thomas Guyot-Sionnest (dermoth)
Assigned to: Thomas Guyot-Sionnest (dermoth)
Summary: check_http doesn't check response time on 300's

Initial Comment:
300's return codes are accepted as OK by default, but
some checks, notably warning/critical time, aren't done
on 300 return codes.

I didn't had time to rewrite this correctly and test it
troughfully, but this simple patch will go on with
other tests when 300's are accepted as OK.

Ideally, response time should be checked when
300!=CRITICAL, and I also on when expecting a string.

----------------------------------------------------------------------

>Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2009-02-03 06:24

Message:
Implemented the max_state logic all the way so that all checks are
performed and appended to the status line.

see commit: 0d781712d7c8405460ab9f2bd9e262d49fe42a3f

----------------------------------------------------------------------

Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2008-01-08 14:42

Message:
Logged In: YES 
user_id=375623
Originator: YES

For the heads up, I just applied it against 1.4.11 and I checked it; it
does not prevent redirects. It only change the behavior if oneredirect ==
STATE_OK and redirs only happens if oneredirect == STATE_DEPENDENT.

However if oneredirect == STATE_WARNING it will not detect critical times
either, so it fix oneredirect == OK (-f ok, default) but not oneredirect ==
STATE_WARNING (-f warning). For that reason it should rather be fixed the
proper way.

The proper fix is likely doing something like following redirect if
oneredirect == STATE_DEPENDENT, otherwise using max_state there and in the
time check section, and properly handling output as well. It will
definitely need careful work and testing, but meanwhile this patch is
*safe* but incomplete.


----------------------------------------------------------------------

Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2007-06-12 19:55

Message:
Logged In: YES 
user_id=375623
Originator: YES

Indeed this patch looks strange... It was not necessarily intended for
inclusion (just a hack), I don't use it anymore and it's been so long I
don't even remember why it wasn't "right"...

I wasn't a NP developer when I submitted it... I'll assign it to myself
and will look over it when I have time (Certainly not until august
unfortunately).

Thomas


----------------------------------------------------------------------

Comment By: Matthias Eble (psychotrahe)
Date: 2007-06-12 14:09

Message:
Logged In: YES 
user_id=1694341
Originator: NO

Hi Thomas,

I looked over the patch and i guess, this would prevent the actual
redirect.
We should also take care of changes to the time measuring behaviour and
mention changes in NEWS or similar so that people don't wonder why their
performance got worse :)
Could you bring up some time look at this?

Matthias




----------------------------------------------------------------------

Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2006-03-28 17:41

Message:
Logged In: YES 
user_id=375623

Forgot the check_box ;)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1460312&group_id=29880