[Nagiosplug-devel] [ nagiosplug-Bugs-2911752 ] check_radius doesn't detect or report authentication errors

[SourceForge.net]

Bugs item #2911752, was opened at 2009-12-09 18:47
Message generated for change (Comment added) made by leres
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2911752&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: release-1.4.15
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Craig Leres (leres)
Assigned to: Thomas Guyot-Sionnest (dermoth)
Summary: check_radius doesn't detect or report authentication errors

Initial Comment:
The check_radius plugin exits with status 0 and no messages if it gets a "result" it isn't expecting. This issue is tickled when you use an incorrect password. In that case, radiusclient returns REJECT_RC (2).

The attached patch (against 1.4.13) adds a case to handle REJECT_RC and also complains if an unexpected result is returned.

Although I did not actually test the snapshot version, examination of the code indicates that 1.4.14-61-g45e2 still has these issues.


----------------------------------------------------------------------

Comment By: Craig Leres (leres)
Date: 2009-12-09 20:24

Message:
I'm using radiusclient-ng 0.5.6 (which although is a few years old also
appears to be the current release) on a FreeBSD 7.2-RELEASE system. I build
radiusclient-ng and nagios-plugins using ports.

% find . -name '*.[ch]' | xargs egrep REJECT_RC
./radiusclient-ng-0.5.6/include/radiusclient-ng.h:#define REJECT_RC     2
./radiusclient-ng-0.5.6/lib/sendserver.c:               result =
REJECT_RC;

----------------------------------------------------------------------

Comment By: Thomas Guyot-Sionnest (dermoth)
Date: 2009-12-09 20:05

Message:
Which library/version are you using for radius? We currently support the
original radiusclient and radiusclient-ng, and none of them provide the
REJECT_RC macro. 

I'll apply the last hunk anyway, but for the rest i'd like to know where
it's from at the very least.

Thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2911752&group_id=29880