[Nagiosplug-devel] check_icmp min and max
Andreas Ericsson
ae at op5.se
Tue Oct 28 20:02:47 CET 2008
rader at hep.wisc.edu wrote:
> > Please re-send with indentation matching that of the surrounding
> > code. That is:
> > * Don't put space after opening parentheses or before closing
> > parentheses.
> > * Put newlines after if() statements.
> > * Put closing curlies on their own lines.
>
> Sure. Sorry for not thinking about the formatting earlier.
> I also checked to make sure all the new code indents with
> hard tabs.
>
>
> > > + host->rtmin = 0xffffffff;
> > > +
> >
> > This should generate a warning, as it would generate bogus assembly
> > without compiler interference. Assign it to a really huge double
> > value instead. Feel free to use scientific notation, like so:
> > #define RTMIN_MAGIC_CONSTANT 50e200
> > host->rtmin = RTMIN_MAGIC_CONSTANT
> >
> > rest assured that that particular magic constant will always be
> > larger than any rtmin you can possibly get, so it won't interfere
> > with the actual setting of the value.
>
> Sure. (I used MAXDOUBLE, da.) Shall I ask a
> Physicist how far across the Universe that'd get us??
>
No need. It's about as far as Marvin walks in the hitchhiker trilogy ;-)
Thanks for the resend.
--
Andreas Ericsson andreas.ericsson at op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
More information about the Devel
mailing list