[Nagiosplug-devel] [ nagiosplug-Patches-2200323 ] check_http timeout problem on http redirection case

[SourceForge.net]

Patches item #2200323, was opened at 2008-10-27 14:04
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2200323&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Artavazd Mertarjyan (armertarj)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_http timeout problem on http redirection case

Initial Comment:
Plugin: check_http v2053 (nagios-plugins 1.4.13)

On the HTTP redirection case, plug-in continues work ignoring timeout specification. Plug-in resets the timer after first response. So, I suggest to set new timer to the remainder of timeout value.

*** check_http.c_old    2008-10-27 08:52:54.000000000 +0000
--- check_http.c        2008-10-27 08:54:15.000000000 +0000
***************
*** 968,974 ****
--- 968,978 ----
      else if (http_status >= 300) {
  
        if (onredirect == STATE_DEPENDENT)
+       {
+         microsec = socket_timeout - deltime(tv)/1.0e6;
+       alarm( microsec>1?microsec:1 );
          redir (header, status_line);
+       }
        else if (onredirect == STATE_UNKNOWN)
          printf (_("HTTP UNKNOWN"));
        else if (onredirect == STATE_OK)



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2200323&group_id=29880