[Nagiosplug-devel] [ nagiosplug-Patches-2089159 ] check_http: extra headers and redirect doesn't work

[SourceForge.net]

Patches item #2089159, was opened at 2008-09-02 16:12
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2089159&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dieter Van de Walle (dietervdw)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_http: extra headers and redirect doesn't work

Initial Comment:
Patch against Plugin Version (-V output):
check_http v1991 (nagios-plugins 1.4.12)
Plugin Name: check_http
Example Plugin Commandline:
./check_http -u "http://somewhere" -f follow -k "header: value"
Tested on operating system: Ubuntu
Tested on architecture: x86
Tested with compiler: gcc version 4.1.3 20080623 (prerelease) (Debian 4.1.2-23)

When adding extra headers and doing a redirect, mayhem occurs. The extra headers are free'd in the first check_http() call, making the second check_http() call after the redir() create a faulty request.
Drop the free(http_opt_headers) .

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2008-11-08 02:32

Message:
Dieter,

Thanks for the report. Fixed in commit 2076.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2089159&group_id=29880