[Nagiosplug-devel] Check_disk plugin update

[Erik Welch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Irrelevant (my earlier email) data truncated.

Comments inline following [erik] as Outlook handles inline comments badly. *feh*

Thanks,
erik
- -----Original Message-----
From: Thomas Guyot-Sionnest [mailto:dermoth at aei.ca] 
Sent: Friday, November 07, 2008 12:46 PM
To: Nagios Plugin Development Mailing List
Subject: Re: [Nagiosplug-devel] Check_disk plugin update

- -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Thanks. The mount_path will be rebuilt on each "-p" invocation... I'll
do some testing myself, but if you don't see any big difference with and
without the patch applied when specifying 10-15 path elements I'd say
it's fine.

[erik] I only specified one path element in my tests, because that is all I need in my environment. If you create a solution to the ARGV issue (below), I suspect that it will also fix the constant re-read of mounted disks.

> I couldn't find a way to add an ARGV to manage the repopulation of mount_list as it needs to happen during process_arguments() in the "case 'p'" section before the np_set_best_match() is executed, but I also couldn't spend much time on this now that I have a working solution...

Easy; I'll take care of it if needed. ;)

[erik] Sweet!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (MingW32)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAkkUuQ4ACgkQgGzpy3g56Sf7tgCgkaKvBhbQYlsAHCO2iGDyZvby
COMAoJ/roIe13hDgPJV2BInB5i3fKmVM
=IjHo
-----END PGP SIGNATURE-----
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------