[Nagiosplug-devel] check_icmp min and max

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/11/08 03:41 PM, Andreas Ericsson wrote:
> Richard Edward Horner wrote:
>>> Solution 2:
>>>
>>>> CRITICAL - 192.168.1.111: Host unreachable @ 192.168.1.116. rta nan, lost 100%|rta=0.000ms;200.000;500.000;0; pl=100%;40;80;;
>>> - From a RRD graphing standpoint, it's better to have no value when data
>>> is unknown, however considering that we already print "rta=0.000" it
>>> would probably look better to do the same with rtamax and rtamin. What
>>> do you think?
>> Sorry if this is a dumb question as I'm not using this plugin in any
>> deployments but why is rta=0.000 getting printed at all in this case?
>> I like Solution 2 here where you omit the min and max values but it
>> seems as though it would make more sense to omit the rta value in this
>> case as well. Am I missing something?
>>
> 
> Search the mailing archives (from around 2004 or 2005, I think), when
> check_icmp was originally added.
> 
>   git log -S'rta=0.000'
> 
> in a clone of the nagiosplug git repo might show you when it was added,
> and possibly why.
> 

Couldn't find anything... I updated my commit with the fix for rtamin,
so both now prints 0.000 (not sure it casts are needed, but I put them
everywhere anyway):

http://solaris.beaubien.net/cgi-bin/gitweb.cgi/nagiosplug-dermoth.git

The end result:
> $ sudo plugins-root/check_icmp -H 192.168.1.111
> CRITICAL - 192.168.1.111: Host unreachable @ 192.168.1.116. rta nan, lost 100%|rta=0.000ms;200.000;500.000;0; pl=100%;40;80;; rtmax=0.000ms;;;; rtmin=0.000ms;;;; 
> $ sudo plugins-root/check_icmp -H 192.168.1.1
> OK - 192.168.1.1: rta 0.940ms, lost 0%|rta=0.940ms;200.000;500.000;0; pl=0%;40;80;; rtmax=1.408ms;;;; rtmin=0.805ms;;;; 

If no one complains loudly I'll commit it tomorrow to SVN

- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJEnmS6dZ+Kt5BchYRAhL5AKCfFlkacuBIwwkgT3sMy3agLzwQGACfb3Wr
R2Xn27QXN8nOOj/LJjO5tlE=
=PmGU
-----END PGP SIGNATURE-----