[Nagiosplug-devel] [ nagiosplug-Bugs-1986306 ] check_dig: no check for mandatory parameter -l

[SourceForge.net]

Bugs item #1986306, was opened at 2008-06-06 13:23
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1986306&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Wagner (cyco_dd)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_dig: no check for mandatory parameter -l

Initial Comment:
The following Bugreport we got against our debian package:

Hiya,

$ ./check_dig -h
check_dig v1590 (nagios-plugins 1.4.11)
[...]
Usage:check_dig -H host -l lookup [-p <server port>] [-T <query type>] [-w <warning interval>] [-c <critical interval>] [-t <timeout>] [-a <expected answer address>] [-v]

"-l lookup" is meant to be a mandatory option. But,

/usr/lib/nagios/plugins$ ./check_dig -H localhost -v
/usr/bin/dig @localhost -p 53 (null) -t A
Looking for: '(null)'
DNS UNKNOWN - 0.767 seconds response time (No ANSWER SECTION found)|time=0.767500s;;;0.000000

asnprintf is called with a NULL parameter. That would cause a
SEGV if GNU libc's asnprintf wasn't nice enough to replace the
NULL with "(null)".

fix would be to report an error if "-l" is not provided.

You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=479013

Thanks and kind regards, Jan.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1986306&group_id=29880