[Nagiosplug-devel] _FILE_OFFSET_BITS in plugins/common.h

[Ton Voon]

On 13 Feb 2008, at 11:47, Thomas Guyot-Sionnest wrote:

> In plugins/common.h there's the following lines:
>
> /* This needs to be removed for Solaris servers, where 64 bit files,  
> but
> 32 bit architecture
>   This needs to be done early on because subsequent system includes  
> use
> _FILE_OFFSET_BITS
>   Cannot remove from config.h because is included by regex.c from  
> lib/ */
> #if __sun__ && !defined(_LP64) && _FILE_OFFSET_BITS == 64
> #undef _FILE_OFFSET_BITS
> #endif
>
> Since I added AC_SYS_LARGEFILE to configure.in it should detect the
> filesystem interfaces available and set _FILE_OFFSET_BITS  
> accordingly in
> config.h. I'm wondering is these lines can be removed... Any ideas?

Not sure. I seem to recall putting it in: http://nagiosplug.svn.sourceforge.net/viewvc/nagiosplug/nagiosplug/trunk/plugins/common.h?r1=1462&r2=1546

It was related to the swapctl functions in check_swap for Solaris. The  
tracker item listed in the changelog is here: http://sourceforge.net/tracker/index.php?func=detail&aid=1588031&group_id=29880&atid=397599

I think I found there was something about the order of the include  
files, where _FILE_OFFSET_BITS was changed later on. Don't know if the  
AC_SYS_LARGEFILE marks it early enough.

Ton

http://www.altinity.com
UK: +44 (0)870 787 9243
US: +1 866 879 9184
Fax: +44 (0)845 280 1725
Skype: tonvoon