[Nagiosplug-devel] Libtap included in distribution

[Andreas Ericsson]

Thomas Guyot-Sionnest wrote:
> |
> | It'll be even easier when you move to git, as you can then use gnulib
> | as ae submodule (Jim Meyering who maintains gnulib is an avid git-fan
> | and contributor) ;-)
> 
> I'm not too sure about this way of doing it, because normally you use
> Gnulib's scripts to update the modules. It's simple and fast.
> 
> It would also mean we'd end up with the whole Gnulib repository rather
> than the subset of modules we included.
> 

Only in your upstream repository, where you can choose to clone a submodule
with --depth 1 to make it really shallow.

For releases it'll make no difference what so ever.

> |> I can't guarantee that we will not include 3rd party software in
> future. We
> |> have to make a judgement on whether a 3rd party piece of code will
> provide
> |> us features or cross platform capabilities we need without
> re-inventing the
> |> wheel. That's a compromise we have to make. However, when possible,
> we will
> |> allow configure options to disable 3rd party code.
> |>
> |
> | Sometimes, reinventing the wheel (or importing a handful of 10-line
> | functions) is preferrable to including the whole shebang.
> 
> And how will you guarantee compatibility across all platform
> Nagios-plugins get compiled on? I don't want to disappoint you but I
> don't see any compelling reason to change the way we do regarding Gnulib

I do. If most of it isn't getting used, then get rid of it and import the
parts that *are* getting used. It's quite possible that the nagiosplugins
gets used on more platforms than gnulib, in which case you'll have to ship
patches upstream every now and then.

If there are bugs in gnulib, you'll have no part of it if it's not part of
the stuff you imported (which, by the sound of it, is unlikely).

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231