[Nagiosplug-devel] Nagios::Plugin perl module integrated into SVN

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ton Voon wrote:
> On 16 Sep 2007, at 06:53, Thomas Guyot-Sionnest wrote:
> 
>> On a side note I just written a Perl plugin for checking M$ SQL
>> databases (attached). It fully uses N::P, including thresholds and
>> performance data (and it's awesome how easy it is now!). Strangely  
>> right
>> after that I noticed there is a bash check_mssql in /contrib so I
>> thought maybe we could include mine as a replacement. I believe it's
>> also a good example of a N::P plugin.
> 
> I'd definitely want an example plugin to include.

check_stuff.pl was a good source of inspiration for me, though
check_mssql is a bit more useful :)

> I've had a quick look through yours (as much as I can without a mssql  
> server) and it looks good. I notice that the contrib version has  

It would certainly work on any database if you change the DB driver and
specify the right port. That could be useful for testing (I don't have
any M$SQL db at home either).

> number of users in the output - could that be added (don't worry  
> about thresholds for that yet)? Then we can remove the contrib version.

I could possibly. I'll have to look around or test since the method used
seems a bit special. This check script query "select loginame from
sysprocesses where spid > $spid order by loginame asc" (where $spid
varies between version 7 and 2000, how about 2005?), filter out a bunch
of lines and count the rest.

However in all honesty I think this kind of check is flaky. I was rather
thinking of a pair of options to override the query and check the result
(optionnal), and another pair to set a label (optionnal) and print the
result. I think that would benefit more people and DBAs can always
create SPROCs to do the dirty work.

> Also, if you want it distributed in the core distribution, could you  
> set the copyright as Nagios Plugins Development Team (you can list  

I have no problem with that.

Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG7tcA6dZ+Kt5BchYRAoVHAKDmkKPIMXUi9+2TGB3+gve1o1rFcQCeOMDu
SMubZtd7Zozuc2K8fTRc3EU=
=Xkqo
-----END PGP SIGNATURE-----