[Nagiosplug-devel] [patch] failing check compromises SNMP community

[Bernhard Fischer]

On Wed, Oct 24, 2007 at 05:12:56PM +0200, Holger Weiss wrote:
>* Bernhard Fischer <rep.dot.nop at gmail.com> [2007-10-24 13:14]:
>> If a check fails then the whole command-line, including the v1 or v2c
>> community string is printed in check_snmp.c
>>
>> The attached proposed patch prints the dummy string "authpriv" instead
>> of the real community, so a failing check does not make the community
>> string visible to the users. Like before the full command_line is
>> printed in verbose mode.
>
>Good point, thank you.  Committed to SVN.

Thanks. IIRC negate also had this problem (but i don't need negate.)

>> PS: I'm attaching nagios-plugins-1.4.10-fix-indentation.diff, which
>> indents check_snmp.c with the options listed on top of the patch.
>
>I didn't commit this as indentation changes make SVN diffs crossing that
>revision unreadable.  Maybe we should nevertheless fix our indentation
>and make it consistent across all plugins in one big commit, but IMO
>this should be discussed, first.

/me as an innocent bystander would certainly welcome if the code was
easier to read. Alot of places are unreadable just because the spacing
and bracing is completely amiss. Merely cosmetics, of course. Still.. :)

cheers,
Bernhard