[Nagiosplug-devel] [patch] failing check compromises SNMP community

[Bernhard Fischer]

Hi,

If a check fails then the whole command-line, including the v1 or v2c
community string is printed in check_snmp.c

The attached proposed patch prints the dummy string "authpriv" instead
of the real community, so a failing check does not make the community
string visible to the users. Like before the full command_line is
printed in verbose mode.

Please apply.

PS: I'm attaching nagios-plugins-1.4.10-fix-indentation.diff, which
indents check_snmp.c with the options listed on top of the patch. The
source was not easily readable otherwise.
The check_snmp-do-not-echo-commandline.diff is ment to be applied ontop
of the fix-indentation.diff.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nagios-plugins-1.4.10-fix-indentation.diff.bz2
Type: application/octet-stream
Size: 10472 bytes
Desc: not available
URL: <http://nagios-plugins.org/archive/devel/attachments/20071024/6c645c3f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nagios-plugins-1.4.10-check_snmp-do-not-echo-commandline.diff
Type: text/x-diff
Size: 3543 bytes
Desc: not available
URL: <http://nagios-plugins.org/archive/devel/attachments/20071024/6c645c3f/attachment.diff>