[Nagiosplug-devel] N::P bug in handling >2 repeated arguments from .ini config

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16/11/07 02:28 PM, Gavin Carr wrote:
> On Fri, Nov 16, 2007 at 11:39:43AM -0500, Thomas Guyot-Sionnest wrote:
>> It applies on 3 and more repeated arguments from the ini file:
>>
>> $ ./check_stuff -D foo,bar,baz
>> CHECK_STUFF OK - Arguments: foo,bar,baz
>>
>> $ ./check_stuff -D foo -D bar -D baz
>> CHECK_STUFF OK - Arguments: foo,bar,baz
>>
>> $ ./check_stuff --extra-opts=check_stuff_test1
>> CHECK_STUFF OK - Arguments: foo,bar,baz
>>
>> $ ./check_stuff --extra-opts=check_stuff_test2
>> CHECK_STUFF OK - Arguments: ARRAY(0x9fd210),baz
>>
>> Just put the ini file in /etc and run the commands above. I attached the
>> patch as well.
> 
> Sorry Thomas, I've been meaning to look at it but haven't had time lately. 
> Your fix looks good to me though, so +1 here.

Committed.

While we're at it, what would you think of including Time::HiRes in the
dependencies? Although not a direct dependency I find most of my N::P
plugins use it to calculate precise runtime, so having it included would
avoid the need to specify this requirement.

Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHPo2o6dZ+Kt5BchYRApPEAKDKrcE6m00UAgS0C8h6W7vJgo0i+wCfTkVG
IzAdA1L5Yh5Oh2flogdPCg4=
=qiS3
-----END PGP SIGNATURE-----