[Nagiosplug-devel] [ nagiosplug-Bugs-1689260 ] check_smtp 1.4.6 local host name never added to helo command

[SourceForge.net]

Bugs item #1689260, was opened at 2007-03-27 15:43
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1689260&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Bill Kunkel (gollum13)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_smtp 1.4.6 local host name never added to helo command

Initial Comment:
It looks like there were some changes between 1.4.5 and 1.4.6 where:

1) the command line option to specify the local host name of the helo command was removed.

and

2) The code that tries to figure out the local host name changed slightly.

subsequently, The local host name is always null (running the plug-in from the command line with the -v option verifies this). This is fine for normal smtp checks, but it causes TLS checks to fail. sendmail (8.14) complains about an invalid domain name and doesn't send back a list of available services like the plug-in is expecting, hence the TLS check returns a warning.

I have attached a patch that should fix the problem.

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2007-03-27 15:54

Message:
Logged In: YES 
user_id=664364
Originator: NO

Bill,

Thanks for the patch. This is already fixed in CVS HEAD. You can try the
snapshot at http://nagiosplug.sf.net/snapshot

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1689260&group_id=29880