[Nagiosplug-devel] [ nagiosplug-Patches-1729581 ] check_ntp - fix for out of order associations

[SourceForge.net]

Patches item #1729581, was opened at 2007-06-01 13:09
Message generated for change (Comment added) made by dermoth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1729581&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Clint Byrum (cbyrum)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_ntp - fix for out of order associations

Initial Comment:
If ntpq returns associations after the sys.peer, it overwrites the jitter with (not parsed)

[root at talk etc]# ntpq -np newskip
     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
+10.10.1.237     132.239.1.6      2 -   15   64   36    0.001    2.005   0.114
+10.10.1.33      60.56.119.79     2 -   50   64   17    0.001  -12.981   2.129
*10.10.1.233     132.239.1.6      2 -   48   64   16    0.001    2.273   0.115
 127.127.1.0     LOCAL(0)        10 l   62   64  377    0.000    0.000   0.001
[root at talk etc]# ../libexec/check_ntp -H newskip
Argument "(not parsed)" isn't numeric in abs at ../libexec/check_ntp line 408.
NTP OK: Offset 0.021792 secs, jitter (not parsed) msec, peer is stratum 2|offset=0.021792, jitter=0,peer_stratum=2

This patch does not address the fact that if there's no match, you'll still get the isn't numeric problem. However if there is a sys peer, it will record a numeric jitter.

----------------------------------------------------------------------

>Comment By: Thomas Guyot (dermoth)
Date: 2007-06-01 13:17

Message:
Logged In: YES 
user_id=375623
Originator: NO

Which version of Nagios-plugins is that?

We're installing a C-based plugin since a few releases now, so either
you're using a very old release or you manually installing the Perl plugin
which has many bugs and is unmaintained.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1729581&group_id=29880