[Nagiosplug-devel] [Pkg-nagios-devel] Bug#392610: nagios-plugins-basic: check_jabber always return warning

[Thomas Guyot-Sionnest]

On 30/01/07 04:00 AM, Jan Wagner wrote:
> Hi Thomas,
> 
>>> I also see one more possible problem. Should it be CRITICAL instead of
>>> WARNING when the output doesn't match? And do you have an external
>>> jabber host to check against so I can make sure the send/expect rules
>>> are right?
>> The attached patch (Also in CVS) will fix the reporting problem. If
>> there's any problem with the jabber check itself (i.e. warning status)
>> I'll need a server to test with. I guess that a bad server response
>> should mean a CRITICAL failure rather than a WARNING, right?
> 
> Try jabber.org as host to check your fixes, this one should be public 
> available.

I tried it but I had to remove the SSL flag in the check_jabber-specific
code. It is always possible to check with ssl with the --ssl
command-line option so I guess I should consider removing that flag.
Otherwise you don't have the option and must check with SSL.

I also left the return code on mismatches to WARNING as it is the
default for every other invocations of check_tcp that set expect
strings. This can be changed as well, using the --mismatch (-M) switch.

The patch I'm committing is attached.

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_tcp.check_jabber-returns-warning.patch
Type: text/x-patch
Size: 901 bytes
Desc: not available
URL: <http://nagios-plugins.org/archive/devel/attachments/20070130/6741cae9/attachment.bin>