[Nagiosplug-devel] [ nagiosplug-Bugs-1653934 ] wrong order of header files in check_swap.c

[SourceForge.net]

Bugs item #1653934, was opened at 2007-02-07 10:14
Message generated for change (Comment added) made by hweiss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1653934&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compilation
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: nsturm (nsturm)
Assigned to: Holger Weiss (hweiss)
Summary: wrong order of header files in check_swap.c

Initial Comment:
In plugins/check_swap.c the order of header files
to include is wrong for at least OpenBSD. sys/param.h
needs to be included before sys/swap.h. See the attached
patch.

----------------------------------------------------------------------

>Comment By: Holger Weiss (hweiss)
Date: 2007-02-07 15:12

Message:
Logged In: YES 
user_id=759506
Originator: NO

Odd, according to swapctl(2), this shouldn't be necessary.  However, I've
committed your patch to CVS.  Thank you very much!

Holger

----------------------------------------------------------------------

Comment By: nsturm (nsturm)
Date: 2007-02-07 14:03

Message:
Logged In: YES 
user_id=1323236
Originator: YES

Here is the error message:

if cc -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I. -I..
-I.. 
-I../lib -I../gl -I../intl -I/usr/include/ldap
-I/usr/local/include/postgresql -
I/usr/include   -I/usr/include/kerberosV -I/usr/local/include  -O2 -pipe
-DLDAP_
DEPRECATED -Wformat -Wbounded -MT check_swap.o -MD -MP -MF
".deps/check_swap.Tpo
" -c -o check_swap.o check_swap.c;  then mv -f ".deps/check_swap.Tpo"
".deps/che
ck_swap.Po"; else rm -f ".deps/check_swap.Tpo"; exit 1; fi
In file included from check_swap.c:46:
/usr/include/sys/swap.h:52: error: `MAXPATHLEN' undeclared here (not in a
function)


----------------------------------------------------------------------

Comment By: Holger Weiss (hweiss)
Date: 2007-02-07 13:29

Message:
Logged In: YES 
user_id=759506
Originator: NO

As I currently don't have access to an OpenBSD box, as <sys/param.h> is
not documented as a general requirement for <sys/swap.h> on OpenBSD[*],
and as I cannot reproduce the problem on NetBSD or FreeBSD: What happens
without your patch?  Could you post the error message you get during
compilation?  Thanks a lot!

Holger

[*] See: http://www.openbsd.org/cgi-bin/man.cgi?query=swapctl

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1653934&group_id=29880