[Nagiosplug-devel] Preparation for release 1.4.11

[Olivier 'Babar' Raginel]

On Tue, Dec 11, 2007 at 10:19:48AM +0000, Ton Voon wrote:
> check_ntp errors:
>    tests are failing on Holger's Vatikan box and tola box (forgot  
> who's that belongs to)

tola is my home box, used to test check_ups.

Here is a detailed output of the errors, which are due to the range of 
~:-1: (I've removed the ok tests, let me know if you need more 
information) Also, I've noted the "Range format incorrect "message 
doesn't contain a newline character at the end, is that on purpose?

$ NPTEST_DEBUG=1 perl t/check_ntp.t
[...skip...]
not ok 20 - check_ntp_peer: Output match no NTP service
#   Failed test 'check_ntp_peer: Output match no NTP service'
#   in t/check_ntp.t at line 73.
#                   'NTP CRITICAL: Server not synchronized, Offset 
unknown|'
#     doesn't match '/^(CRITICAL - Socket timeout after 3 seconds)|(NTP 
CRITICAL: No response from NTP server)$/'

[...skip...]

testCmd: Called from line 99 in t/check_ntp.t
Testing: ./check_ntp_peer -H pool.ntp.org -w 1000 -c 2000 -W ~:-1 -C 21 
-j 100000 -k 200000
Output:  Range format incorrect
Return code: 3
not ok 39 - check_ntp_peer: Warning NTP result with jitter and stratum 
check
#   Failed test 'check_ntp_peer: Warning NTP result with jitter and 
stratum check'
#   in t/check_ntp.t at line 102.
#          got: 3
#     expected: 1
not ok 40 - check_ntp_peer: Output match WARNING with jitter and stratum
#   Failed test 'check_ntp_peer: Output match WARNING with jitter and 
stratum'
#   in t/check_ntp.t at line 103.
#                   'Range format incorrect'
#     doesn't match 
'/^NTP\sWARNING:\sOffset\s-?[0-9]+(\.[0-9]+)?(e-[0-9]{2})?\ssecs,\sjitter=[0-9]+\.[0-9]+,\sstratum=[0-9]{1,2}/'
testCmd: Called from line 105 in t/check_ntp.t
Testing: ./check_ntp_peer -H pool.ntp.org -w 1000 -c 2000 -W 20 -C 21 -j 
100000 -k ~:-1
Output:  Range format incorrect
Return code: 3
not ok 41 - check_ntp_peer: Critical NTP result with jitter and stratum 
check
#   Failed test 'check_ntp_peer: Critical NTP result with jitter and 
stratum check'
#   in t/check_ntp.t at line 108.
#          got: 3
#     expected: 2
not ok 42 - check_ntp_peer: Output match CRITICAL with jitter and 
stratum
#   Failed test 'check_ntp_peer: Output match CRITICAL with jitter and 
stratum'
#   in t/check_ntp.t at line 109.
#                   'Range format incorrect'
#     doesn't match 
'/^NTP\sCRITICAL:\sOffset\s-?[0-9]+(\.[0-9]+)?(e-[0-9]{2})?\ssecs,\sjitter=[0-9]+\.[0-9]+,\sstratum=[0-9]{1,2}/'
# Looks like you failed 5 tests of 42.


So 4 tests fail because of range format incorrect, other one seems to be 
that the error message returned is not the one the tests expects. As I 
don't really understand why it shouldn't return this message (from the 
code, it looks fine), I can't help you.

Let me know if you need to test anything else.

Kind regards,

-- 
Babar.