[Nagiosplug-devel] [ nagiosplug-Bugs-1703759 ] Unnecessary ${SHELL} in INSTALL_STRIP_PROGRAM options

[SourceForge.net]

Bugs item #1703759, was opened at 2007-04-19 17:27
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1703759&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compilation
Group: Release (specify)
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Nico Kadel-Garcia (nkadelgarcia)
>Assigned to: Ton Voon (tonvoon)
Summary: Unnecessary ${SHELL} in  INSTALL_STRIP_PROGRAM options

Initial Comment:
The presence in configure and configure.in of the unnecessary %{SHELL} means that attempts to use /usr/bin/install instead of install-sh fail miserably, and for no valid reason.

The patch is below:


diff -ur nagios-plugins-1.4.8/aclocal.m4 nagios-plugins-1.4.8.chmod/aclocal.m4
--- nagios-plugins-1.4.8/aclocal.m4     2007-04-11 08:11:58.000000000 -0400
+++ nagios-plugins-1.4.8.chmod/aclocal.m4       2007-04-19 11:07:41.000000000 -0400
@@ -7158,7 +7158,7 @@
 if test "$cross_compiling" != no; then
   AC_CHECK_TOOL([STRIP], [strip], :)
 fi
-INSTALL_STRIP_PROGRAM="\${SHELL} \$(install_sh) -c -s"
+INSTALL_STRIP_PROGRAM="\$(install_sh) -c -s"
 AC_SUBST([INSTALL_STRIP_PROGRAM])])

 # Check how to create a tarball.                            -*- Autoconf -*-
diff -ur nagios-plugins-1.4.8/configure nagios-plugins-1.4.8.chmod/configure
--- nagios-plugins-1.4.8/configure      2007-04-11 08:12:37.000000000 -0400
+++ nagios-plugins-1.4.8.chmod/configure        2007-04-19 11:11:31.000000000 -0400
@@ -2007,7 +2007,7 @@
 fi

 fi
-INSTALL_STRIP_PROGRAM="\${SHELL} \$(install_sh) -c -s"
+INSTALL_STRIP_PROGRAM="\$(install_sh) -c -s"

 # We need awk for the "check" target.  The system "awk" is bad on
 # some platforms.


----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2007-04-23 20:02

Message:
Logged In: YES 
user_id=664364
Originator: NO

Hi Nico,

aclocal.m4 is generated by autoconf, and it looks like the section for
INSTALL_STRIP_PROGRAM is outside of the control of the Nagios Plugins
project.

According to the information in aclocal.m4, it says:

# Fortunately install-sh will honor a STRIPPROG variable, so we
# always use install-sh in `make install-strip', and initialize
# STRIPPROG with the value of the STRIP variable (set by the user).

So it looks like install-sh is always used, but you can control the strip
program by use of the STRIP env var.

I've marked this call in PENDING because I don't think there's anything we
can do about this.

Ton

----------------------------------------------------------------------

Comment By: Nico Kadel-Garcia (nkadel)
Date: 2007-04-20 01:50

Message:
Logged In: YES 
user_id=923047
Originator: NO

Dang. There are other fascinating little interactions, that interfere at
least with installation as non-root users in various other ways.

The DAG RPM's get around this by completely ignoring the "make install"
option and doing it manually in the .spec files. It's a shame to have to do
that.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1703759&group_id=29880