[Nagiosplug-devel] Flight 1.4.8, ready for boarding

[Thomas Guyot-Sionnest]

On 02/04/07 09:52 PM, Holger Weiss wrote:
> * Thomas Guyot-Sionnest <dermoth at aei.ca> [2007-04-02 01:10]:
>> On 31/03/07 02:53 PM, Holger Weiss wrote:
>>> The memcpy(3) following the realloc(3) call writes out of bounds as soon
>>> as peer_offset is >0.  I committed the following patch: [...]
>>>
>>> Could you test whether this fixes the problem for you?
>> Well, strangely I couldn't reproduce the problem. What's even stranger
>> is that I haven't recompiled anything since then. Thanks for fixing
>> whatever was wrong there though :)
> 
> JFTR, this fix is only relevant if the READSTAT do/while() loop in
> jitter_request() is executed more than once (in which case peer_offset
> is >0).  While this usually won't happen (so that the problem wasn't
> easily reproducible), my guess is that it did happen in your case.

This likely happened sometimes when it was reading an old NTP packet
before tonight's fix. Every time this happened (reading an old NTP
packet, and it did very often) the results were totally random.

Thomas