[Nagiosplug-devel] [ nagiosplug-Bugs-1494629 ] 1.4.6 (& .3 & .5) - check_icmp fails after a time on FreeBSD

[SourceForge.net]

Bugs item #1494629, was opened at 2006-05-25 06:41
Message generated for change (Comment added) made by mfavas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1494629&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: Release (specify)
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Mark Favas (mfavas)
Assigned to: Thomas Guyot (dermoth)
Summary: 1.4.6 (& .3 & .5) - check_icmp fails after a time on FreeBSD

Initial Comment:
Current release (1.4.3) check_icmp on FreeBSD 6.1 works
fine for some hours, then reports 100% packet loss.
This is due to the plugin not allowing for the fact
that PIDs can be greater than 65535 (i.e. more than 16
bits) on  systems such as FreeBSD. Further details are
given in
http://article.gmane.org/gmane.network.nagios.plugins/1945 
. A version of check_icmp available from Andreas fixes
this issue. This version has an earlier date associated
with it than the version distributed in nagios-plugins,
but a higher revsion number. Quote:

"""
If the fix isn't available in a recent package from the
official 
nagiosplug package you should be able to use the one
found at 
http://oss.op5.se/nagios/check_icmp-2005-06-01.tar.gz

You can notice if the fix is available from the
nagiosplug project by doing

$ grep -q 'pid & 0xffff' check_icmp.c && echo "Fix
available"

"""

----------------------------------------------------------------------

>Comment By: Mark Favas (mfavas)
Date: 2007-04-02 06:06

Message:
Logged In: YES 
user_id=44979
Originator: YES

Thanks for the quick response - I've tested the patch over the last week
and everything looks good.

----------------------------------------------------------------------

Comment By: Thomas Guyot (dermoth)
Date: 2007-03-27 14:55

Message:
Logged In: YES 
user_id=375623
Originator: NO

Sorry, last comment was sent too early in error. The code have just been
committed and the patch is attached.
File Added: check_icmp.32bit-pid_t.patch

----------------------------------------------------------------------

Comment By: Thomas Guyot (dermoth)
Date: 2007-03-27 14:32

Message:
Logged In: YES 
user_id=375623
Originator: NO

Thanks for reporting. I fixed it in CVS so you can either pull the HEAD
revision (Or wait for the next snapshot) or use the attached patch.

----------------------------------------------------------------------

Comment By: Mark Favas (mfavas)
Date: 2007-03-25 07:31

Message:
Logged In: YES 
user_id=44979
Originator: YES

This bug still exists in 1.4.6, with FreeBSD 6.2 - would really appreciate
a fix in the officially-released plugin code.

----------------------------------------------------------------------

Comment By: Mark Favas (mfavas)
Date: 2006-12-02 18:29

Message:
Logged In: YES 
user_id=44979
Originator: YES

This bug still exists in version 1.4.5

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1494629&group_id=29880