[Nagiosplug-devel] [ nagiosplug-Patches-1492491 ] check_dhcp network iface name too small (cf. bug #1286235)

[SourceForge.net]

Patches item #1492491, was opened at 2006-05-21 14:00
Message generated for change (Comment added) made by egalstad
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1492491&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
Status: Closed
Resolution: None
Priority: 5
Submitted By: Vincent Zanotti (amidebx)
Assigned to: Ethan Galstad (egalstad)
Summary: check_dhcp network iface name too small (cf. bug #1286235)

Initial Comment:
Network interface name is only of 7 real chars (8 including final \0).
VLAN interfaces need longer names ("eth1.1230" is 10 characters long).

Normal Linux systems allow interface names of up to 16 characters (cf <linux/if.h>, constant IFNAMSIZ). check_dhcp uses this constant IFNAMESIZ a few time.

My patch changes

char network_interface_name[8]="eth0";

into

#if IFNAMSIZ > 8
char network_interface_name[IFNAMSIZ]="eth0";
#else
char network_interface_name[8]="eth0";
#endif

so it keeps compatibility with other systems which do not have IFNAMSIZ >= 8 ...

----------------------------------------------------------------------

Comment By: Ethan Galstad (egalstad)
Date: 2006-05-25 17:01

Message:
Logged In: YES 
user_id=2225

this patch has been committed to the nagiosplug CVS repository. 
thank you for your contribution.

----------------------------------------------------------------------

Comment By: Ethan Galstad (egalstad)
Date: 2006-05-25 17:00

Message:
Logged In: YES 
user_id=2225

this patch has been committed to the nagiosplug CVS repository. 
thank you for your contribution.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1492491&group_id=29880