[Nagiosplug-devel] [ nagiosplug-Bugs-1481615 ] Problem with check_disk
SourceForge.net
noreply at sourceforge.net
Thu Jul 20 01:15:41 CEST 2006
Bugs item #1481615, was opened at 2006-05-04 07:04
Message generated for change (Comment added) made by tonvoon
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1481615&group_id=29880
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Submitted By: Tobias Mucke (mucke)
Assigned to: Ton Voon (tonvoon)
Summary: Problem with check_disk
Initial Comment:
Hi everybody,
yesterday I tried the new plugin version 1.4.3. I
experienced a problem with check_disk. Here is the
output. Filesystem /home is a reiserfs. I guess that's
the reason for inode=nan%?. But that's not the problem.
Look at the performance data. In the MIN field. It
should be 0 but it is -2147483648.
/opt/nagios/plugins/check_disk -w 20 -c 10 -p /home
DISK OK - free space: /home 480 MB (94% inode=nan%);|
/home=32MB;491;501;-2147483648;511
Thanks in advance.
Tobias
----------------------------------------------------------------------
>Comment By: Ton Voon (tonvoon)
Date: 2006-07-20 00:15
Message:
Logged In: YES
user_id=664364
Tobias,
Can you please try the latest snapshot? The min value has been removed
(which is one way of fixing your original problem :) ). But the values
calculated should now be consistent with df output.
The inode value will be printed as "-" which is consistent with df -i.
Ton
----------------------------------------------------------------------
Comment By: Tobias Mucke (mucke)
Date: 2006-06-19 06:43
Message:
Logged In: YES
user_id=481892
Hi everybody,
sorry, since I am not a C programmer I can't figure out the
problem, but it still persists. Tried newest plugin version.
~> /opt/nagios/plugins/check_disk --version
check_disk (nagios-plugins 1.4.3) 1.67
~> /opt/nagios/plugins/check_disk -p /home
DISK OK - free space: /home 480 MB (94% inode=nan%);|
/home=32MB;511;511;-2147483648;511
I reopend the call again. Thanks.
Tobias
----------------------------------------------------------------------
Comment By: Ton Voon (tonvoon)
Date: 2006-06-15 08:52
Message:
Logged In: YES
user_id=664364
Hi all!
The patch by Ralph is already applied to CVS in check_disk.c v1.67. Please try
the snapshot at http://nagiosplug.sf.net/snapshot.
I'm putting this call into pending.
Ton
----------------------------------------------------------------------
Comment By: Olexandr Davydenko (blackraven1977)
Date: 2006-06-15 08:12
Message:
Logged In: YES
user_id=1526665
Hi everybody!
I have similar problem on FreeBSD 6.1 with check_disk.c,v
1.64 2006/03/27 08:19:01
Ralph RöÃner patch solved this problem.
----------------------------------------------------------------------
Comment By: Tobias Mucke (mucke)
Date: 2006-05-18 10:28
Message:
Logged In: YES
user_id=481892
Hi everybody,
checked out newest snapshot 20060517 but same problem.
Tobias
----------------------------------------------------------------------
Comment By: Ralph RöÃner (ralph_roessner)
Date: 2006-05-08 19:08
Message:
Logged In: YES
user_id=1515003
Hi everybody!
I have a similar problem on Solaris, only I get bitten by
validate_arguments(), which complains that "C_IDFP
(67065044...467904.000000) should be less than W_IDFP
(0.0)". It appears that the minimum free inode percentage
was not correctly initialized. This only appears when file
systems are selected with "-p".
The reason I suspect is that the c_idfp and w_idfp members
of the path list structure are never initialized in this
case, at least not at the point where c_dfp and w_dfp are
(check_disk.c lines 457ff). So random malloc()ed memory is
passed to validate_arguments(), and the results vary
according to architecture and phase of the moon.
I created a patch that treats the [cw]_idfp like [cw]_dfp at
the point where the "-p" argument is parsed. This makes the
problem go away for me. If there are other places where the
path list is added to then there is a good chance that the
same oversight happened there too.
Since I don't find a way to attach a file to a thread I did
not open, I will include the patch here:
--8><-----------------------------------
*** nagios-plugins-1.4.3/plugins/check_disk.c.orig Mon
May 8 19:50:33 2006
--- nagios-plugins-1.4.3/plugins/check_disk.c Mon May 8
19:49:48 2006
***************
*** 462,467 ****
--- 462,469 ----
se->c_df = c_df;
se->w_dfp = w_dfp;
se->c_dfp = c_dfp;
+ se->w_idfp = w_idfp;
+ se->c_idfp = c_idfp;
se->found = 0;
se->found_len = 0;
*pathtail = se;
--8><-----------------------------------
Hope this helps,
Ralph RöÃner
----------------------------------------------------------------------
Comment By: Tobias Mucke (mucke)
Date: 2006-05-05 15:20
Message:
Logged In: YES
user_id=481892
Ton,
checked it, but same problem.
----------------------------------------------------------------------
Comment By: Ton Voon (tonvoon)
Date: 2006-05-05 09:37
Message:
Logged In: YES
user_id=664364
Tobias,
Can you check the snapshot at http://nagiosplug.sf.net/snapshot? There was a
fix reported for inode problems on Solaris, but probably applicable to reiserfs
too.
Ton
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1481615&group_id=29880
More information about the Devel
mailing list