[Nagiosplug-devel] [ nagiosplug-Patches-1588031 ] check_swap coredump fix for solaris

[SourceForge.net]

Patches item #1588031, was opened at 2006-10-31 16:57
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1588031&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Duncan Ferguson (duncan_ferguson)
>Assigned to: Ton Voon (tonvoon)
Summary: check_swap coredump fix for solaris

Initial Comment:
check_swap in plugins 1.4.4 coredumps on solaris (and
other SVR4 hosts) when swapctl returns an unexpected
value.  This patch provides a tidier exit and also
checks for some malloc errors in allocating memory for
the vars used.

I have not amended the BSD section for the same
problems since I have no way of testing if the changes
I make are sane.

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2006-12-07 16:09

Message:
Logged In: YES 
user_id=664364
Originator: NO

Duncan,

Thanks for the patch. Turns out part of the problem is the
_FILE_OFFSET_BITS definition causes problems in various places. Including
sys/stat.h at the beginning of check_swap works, but was better to remove
the definition in common.h.

Please try the snapshot and let us know if this fixes. Have only tested on
a 64bit Solaris 9 server.

Ton

----------------------------------------------------------------------

Comment By: Andy Harrison (nachoz)
Date: 2006-11-09 19:07

Message:
Logged In: YES 
user_id=27741

I ran into the issue of check_swap dumping core on Solaris 9
(sparc).  Using this patch fixed the problem perfectly. 
Thanx!  -- Andy

----------------------------------------------------------------------

Comment By: Duncan Ferguson (duncan_ferguson)
Date: 2006-11-01 14:31

Message:
Logged In: YES 
user_id=865292

Updated patch to fix the "Bad Address" problem for solaris.
 Includes previous patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1588031&group_id=29880