[Nagiosplug-devel] [ nagiosplug-Feature Requests-1341528 ] configure options to skip program autodetection

[SourceForge.net]

Feature Requests item #1341528, was opened at 2005-10-29 08:17
Message generated for change (Settings changed) made by seanius
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Priority: 5
Submitted By: Elan Ruusamäe (ahmake)
Assigned to: M. Sean Finney (seanius)
Summary: configure options to skip program autodetection

Initial Comment:
hi 
 
this patch adds commandline arguments to specify 
location of programs to be used, so the programs 
are not needed to exist at compile time in system, 
but plugins are usable. 
 
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-configure.patch  
 
please be so kind and apply in your cvs. 
 
note: the ps program related patch chunk 
creates .rej with current snapshot 
(200510290447), but if you apply the rest, i'm 
happy to make that portion compatible with current 
cvs code. 

----------------------------------------------------------------------

>Comment By: M. Sean Finney (seanius)
Date: 2005-11-07 07:50

Message:
Logged In: YES 
user_id=226838

hi elan,

i've merged your patch into the latest cvs, thanks!

i've made the following modifications:

- all the AC_ARG_WITH statements were modified to use
ACX_HELP_STRING in their descriptions
- a couple other random cosmetic changes (PATH instead of
<path>, etc)
- changed "with-cols" to "with-ps-cols"

at some later time, i may take another pass over the entire
configure.in script to try and clean up and consolidate the
detection code, but what you've provided seems to work from
my initial testing, so... it's in.

thanks again,
sean

----------------------------------------------------------------------

Comment By: Elan Ruusamäe (ahmake)
Date: 2005-11-04 21:34

Message:
Logged In: YES 
user_id=289546

(thank you sourceforge for discarding my first post as i  
wasn't logged in)  
  
sorry for the delay, i've got carried away with work last  
week  
  
i've updated the patch to apply against 200510310547  
snapshot.  
 
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-configure.patch?rev=1.6.2.1 
 
regarding the  ac_cv_ping_has_timeout=yes, it was 
already broken by design. ie if --with-ping-command 
was supplied it was set to no. perhaps add configure 
options for those two options (see below)? 
 
here's the configure.ac snippet: 
AC_MSG_CHECKING(for ICMP ping syntax) 
ac_cv_ping_packets_first=no 
ac_cv_ping_has_timeout=no 
if test -n "$with_ping_command" 
then 
    AC_MSG_RESULT([(command-line) 
$with_ping_command]) 
    if test -n "$ac_cv_ping_packets_first" 
    then 
        ac_cv_ping_packets_first=yes 
        ac_cv_ping_has_timeout=yes 
    fi 
 
 
 

----------------------------------------------------------------------

Comment By: Elan Ruusamäe (ahmake)
Date: 2005-10-29 10:12

Message:
Logged In: YES 
user_id=289546

ok. i've updated the /proc/loadavg to be also with 
commandline arg. 
 
ac_cv_ping_has_timeout needs more look, i guess it 
was added because there was no way to do it with 
commandline. i'll look on this later, perhaps on monday. 

----------------------------------------------------------------------

Comment By: M. Sean Finney (seanius)
Date: 2005-10-29 08:42

Message:
Logged In: YES 
user_id=226838

hi elan,

this would be a wonderful feature to have.  as i'm also
maintaining the debian distribution's package, i'm very much
in the same situation as you.  the previous maintainer
issued build-dependencies on these packages, which was not
only an
ugly hack but also problematic, as some of the dependencies
tried to install daemons on the debian build-hosts :)

my current approach was to patch common.h to include a
"debian.h" that had everything hardcoded, which isn't the
most "graceful" way

anyway, if you could supply a version that works against the
current configure.in in cvs HEAD, i'd be more than willing
to include it.  also, could you comment on the first two
hunks in the patch?  not sure what the first one does and
the second looks like it would have problems on non-linux hosts.

thanks,
        sean

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880