[Nagiosplug-devel] [ nagiosplug-Patches-1150777 ] check_ntp.pl offset boundary condition fix

[SourceForge.net]

Patches item #1150777, was opened at 2005-02-24 05:26
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1150777&group_id=29880

Category: Enhancement
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: John Warburton (johnwarburton)
Assigned to: Ton Voon (tonvoon)
Summary: check_ntp.pl offset boundary condition fix

Initial Comment:
Version 1.20 of check_ntp.pl from
nagios-plugins-HEAD-200502231747

According to the code:

"An offset of 0.000000 with an error is probably bogus.
Actually, it's probably always bogus, but let's be
paranoid here."

Well, in the 3 weeks of running check_ntp.pl here, I
have received this error twice, on different servers:

[02-24-2005 16:04:05] SERVICE ALERT: dory;Check
NTP;CRITICAL;SOFT;1;NTP CRITICAL: server 1.2.3.4,
stratum 2, offset 0.000000, delay 0.02588

[02-13-2005 17:37:51] SERVICE ALERT: plod;Check
NTP;CRITICAL;SOFT;1;NTP CRITICAL: server 1.2.3.4,
stratum 2, offset 0.000000, delay 0.02599

I suggest we remove this check as an offset of 0.000000
is not bogus. It happens.

Patch attached.

John

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2005-03-08 06:20

Message:
Logged In: YES 
user_id=664364

Thanks John. I've added a comment in to the code.

----------------------------------------------------------------------

Comment By: John Warburton (johnwarburton)
Date: 2005-03-07 23:38

Message:
Logged In: YES 
user_id=1192023

Sorry about the delay - has been a busy week.

This is all running on Solaris 8 with the Solaris NTP daemon
- xntpd

John

----------------------------------------------------------------------

Comment By: Ton Voon (tonvoon)
Date: 2005-03-04 22:20

Message:
Logged In: YES 
user_id=664364

John,

I am happy to apply the changes on CVS HEAD, but not on the patches 
for 1.4 yet as I do not know why it this check was added. Instead of your 
patch of removing comments, I've added in extra ones to reference this 
call.

Can you state your OS and ntp version please as the offset result maybe 
a problem to a specific level of software. I'll add that into the comments.

Thanks for the bug report.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1150777&group_id=29880