[Nagiosplug-devel] [ nagiosplug-Patches-1041576 ] starttls support for check_smtp

[SourceForge.net]

Patches item #1041576, was opened at 2004-10-06 11:10
Message generated for change (Comment added) made by chen23
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1041576&group_id=29880

Category: Enhancement
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Submitted By: Eric Chen (chen23)
Assigned to: Benoit Mortier (opensides)
Summary: starttls support for check_smtp

Initial Comment:
added starttls support and certifcate check to check_smtp
code borrowed from check_http.c

also requires additional change to plugin/Makefile.am:

check_smtp_LDADD = $(NETLIBS) $(SSLLIBS)

patches against nagios-plugins-1.3.1
built on Solaris 9 w/ Forte Developer 7 C 5.4

----------------------------------------------------------------------

>Comment By: Eric Chen (chen23)
Date: 2005-01-03 16:37

Message:
Logged In: YES 
user_id=271106

Hi,

I'm not sure if i understand completely, but according to a colleague of 
mine "__sun" is what forte uses.  

I'd recommend creating a separate ticket, b/c I couldn't get check_dhcp 
to run under Solaris 9 (got a bus error).

Independent of the problem with check_dhcp, the changes to check_smtp 
look fine.

  -eric

----------------------------------------------------------------------

Comment By: Benoit Mortier (opensides)
Date: 2005-01-03 16:32

Message:
Logged In: YES 
user_id=388184

Hi, 
 
i am willing to apply your patch but i didnt' understand why you 
removed the two __ after sun ?? 
 
Could you explain further to me .. 
 
thanks 

----------------------------------------------------------------------

Comment By: Eric Chen (chen23)
Date: 2005-01-03 13:45

Message:
Logged In: YES 
user_id=271106

patch for check_dhcp.c against 1.4-beta1
problem existed for compiling check_dhcp.c under Solaris 9 w/ Forte 
Developer 7 C 5.4



----------------------------------------------------------------------

Comment By: Eric Chen (chen23)
Date: 2005-01-03 13:17

Message:
Logged In: YES 
user_id=271106

ok under fedora core 3
fails under solaris 9 (sparc) w/ forte developer 7 c 5.4

tested against: nagios-plugins-1.4-beta1

error under solaris: (during make)

...
Making all in plugins
source='check_dhcp.c' object='check_dhcp.o' libtool=no depfile='.deps/check_dhcp.Po' tmpdepfile='.deps/check_dhcp.TPo' depmode=none /bin/bash ../depcomp cc -DLOCALEDIR=\/usr/local/nagios/share/locale\ -DHAVE_CONFIG_H 
-I. -I. -I.. -I.. -I../lib -I../intl  -I/usr/include/ldap   -I/usr/local/include  -g 
-c check_dhcp.c
"check_dhcp.c", line 130: syntax error before or at: u_int8_t
"check_dhcp.c", line 130: cannot recover from previous errors
cc: acomp failed for check_dhcp.c
*** Error code 2
make: Fatal error: Command failed for target `check_dhcp.o'
Current working directory /home/emchen/nagios-plugins-1.4-beta1/
plugins
*** Error code 1
make: Fatal error: Command failed for target `all-recursive'
Current working directory /home/emchen/nagios-plugins-1.4-beta1
*** Error code 1
make: Fatal error: Command failed for target `all'

----------------------------------------------------------------------

Comment By: Benoit Mortier (opensides)
Date: 2004-12-28 18:19

Message:
Logged In: YES 
user_id=388184

Hi, 
 
patches commited to cvs, will appear in public cvs in a couple of hours. 
 
Could you test it ? 
 
thanks 

----------------------------------------------------------------------

Comment By: Eric Chen (chen23)
Date: 2004-12-15 14:39

Message:
Logged In: YES 
user_id=271106

updated patch against CVS HEAD 200412150547 
tested on Fedora Core 3


----------------------------------------------------------------------

Comment By: Benoit Mortier (opensides)
Date: 2004-12-07 17:35

Message:
Logged In: YES 
user_id=388184

Hi, 
 
could you provide a patch against cvs head, this one is to old 
 
Thanks 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1041576&group_id=29880