[Nagiosplug-devel] [ nagiosplug-Patches-1262777 ] Fix subst.in for non-upgrades

[SourceForge.net]

Patches item #1262777, was opened at 2005-08-18 08:01
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1262777&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Phil Dibowitz (jaymzh)
Assigned to: Ton Voon (tonvoon)
Summary: Fix subst.in for non-upgrades

Initial Comment:
The following patch takes out the call to the which()
function, and the which() function itself in the
subst.in awk script.

This script attempts to determine if the libexec
directory exists, and if it doesn't, it changes the
"use lib" path to be relative instead of absolute.

The problem is that the path is _about_ to exist (after
"make install"), but doesn't yet exist... so on
upgrades, this works, but on fresh installs,  you have
a "use lib" path that is relative and thus can't be
called from nrpe in any useful way.

While I see the theory of making things relative in the
event the absolute path doesn't exist, the absolute
path is about to exist, so making a decision on the
presence of something you know you are about to make is
quite silly.

This fixes it and allows us to build RPMs of
nagios-plugins in a chroot'd environment (like mach -
mach.sf.net).

This patch is against nagios-plugins-1.3.1.

Thanks,
Phil

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2005-08-30 22:23

Message:
Logged In: YES 
user_id=664364

Cannot recreate this problem. Still speaking to Phil re: steps to recreate.

----------------------------------------------------------------------

Comment By: Phil Dibowitz (jaymzh)
Date: 2005-08-22 10:04

Message:
Logged In: YES 
user_id=533101

OK... still a moron. Didn't check the little box. Lets try
this again.

----------------------------------------------------------------------

Comment By: Phil Dibowitz (jaymzh)
Date: 2005-08-22 10:03

Message:
Logged In: YES 
user_id=533101

OK, I'm a moron, I forgot to attach the patch. Here it is.

- Phil

----------------------------------------------------------------------

Comment By: Ton Voon (tonvoon)
Date: 2005-08-19 08:42

Message:
Logged In: YES 
user_id=664364

Phil,

Thanks for the patch. I will take a look at this today.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1262777&group_id=29880