[Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug in check_tcp

[SourceForge.net]

Bugs item #1181554, was opened at 2005-04-12 17:27
Message generated for change (Comment added) made by sb-netman
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Simon Bellwood (sb-netman)
Assigned to: Nobody/Anonymous (nobody)
Summary: 1.4-3: Bug in check_tcp

Initial Comment:
I'm using check_imap with perfparse, and it's returning
critical for all values.

It seems the problem is that when no critical or
warning value is passed to it on the command line, it
defaults to use 0.000 and 0.000 respectively. Perfparse
then sees that the check time (say 0.002 seconds) is
above 0 and flags a CRITICAL warning.

I've had a look at the code, and the return happens at
check_tcp.c:389, where fperfdata is called.
fperfdata is provided by utils.h which sets both types
to a double, so I suspect it's not as simple as
changing check_tcp.c to return nulls if the -w and -c
flags aren't given :/

----------------------------------------------------------------------

>Comment By: Simon Bellwood (sb-netman)
Date: 2005-04-18 09:01

Message:
Logged In: YES 
user_id=1156501

I was hoping that one of the developers would either say:
i) Oh no wait, there's an easy fix for this
ii) Tell perfparse to treat 0.0 as "no value"

Although ii) might be wrong in some cases, i.e. when 0 was
considered a good value (perhaps for items where a measure
from the normal was taken - can' think of any examples atm)

----------------------------------------------------------------------

Comment By: M. Sean Finney (seanius)
Date: 2005-04-18 00:14

Message:
Logged In: YES 
user_id=226838

hi,

what exactly are you suggesting as a fix?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880