[Nagiosplug-devel] small patches to check_nt
Ton Voon
tonvoon at mac.com
Wed Mar 31 15:12:04 CEST 2004
Fixed the command line bug in v1.22 - thanks.
I think I'll need Karl to adjudicate on the single line usage output
and the other patches with regards to the new perl framework.
On 31 Mar, 2004, at 09:52, Howard Wilkinson wrote:
> This patch to check_nt fixes a command argument bug. It also outputs
> the usage on a single line, which needs to be reversed out, but we
> need for our current system.
>
>
>
> This message contains confidential information and is intended only
> for the individual named. If you are not the named addressee you
> should not disseminate, distribute or copy this e-mail. Please
> notify the sender immediately by e-mail if you have received this
> e-mail by mistake and delete this e-mail from you system.
>
> E-mail transmission cannot be guarenteed to be secure or error-free
> as information could be intercepted, corrupted, lost, destroyed,
> arrive late or incomplete, or contain viruses. The sender therefore
> does not accept liability for any errors or omissions in the contents
> of this message which arise as a result of e-mail transmission. If
> verification is required please request a hard-copy version.
> diff -ruN nagios-plugins-1.4.0alpha1-save/plugins/check_nt.c
> nagios-plugins-1.4.0alpha1/plugins/check_nt.c
> --- nagios-plugins-1.4.0alpha1-save/plugins/check_nt.c 2003-11-12
> 05:53:06.000000000 +0000
> +++ nagios-plugins-1.4.0alpha1/plugins/check_nt.c 2004-03-18
> 23:34:49.000000000 +0000
> @@ -180,7 +180,7 @@
>
> if (value_list==NULL)
> output_message = strdup (_("missing -l parameters"));
> - else if (strlen(value_list)==1)
> + else if (strlen(value_list)!=1)
> output_message = strdup (_("wrong -l argument"));
> else {
> asprintf(&send_buffer,"%s&4&%s", req_password, value_list);
> @@ -587,7 +587,7 @@
> void print_usage(void)
> {
> printf(_("\
> -Usage: %s -H host -v variable [-p port] [-w warning] [-c critical]\n\
> - [-l params] [-d SHOWALL] [-t timeout]\n"), progname);
> +Usage: %s -H host -v variable [-p port] [-w warning] [-c critical]\
> + [-l params] [-d SHOWALL] [-t timeout]\n"), progname);
> printf (_(UT_HLP_VRS), progname, progname);
> }
> /
> ***********************************************************************
> *******
> *
> * CHECK_NT.C
> *
> * Program: Windows NT plugin for NetSaint
> * License: GPL
> * Copyright (c) 2000-2002 Yves Rubin (rubiyz at yahoo.com)
> *
> * Description:
> *
> * This requires NSClient software to run on NT
> (http://nsclient.ready2run.nl/)
> *
> * License Information:
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> * the Free Software Foundation; either version 2 of the License, or
> * (at your option) any later version.
> *
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> *
> * You should have received a copy of the GNU General Public License
> * along with this program; if not, write to the Free Software
> * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> *
>
> ***********************************************************************
> ******/
>
> #include "common.h"
> #include "netutils.h"
> #include "utils.h"
>
> enum checkvars {
> CHECK_NONE,
> CHECK_CLIENTVERSION,
> CHECK_CPULOAD,
> CHECK_UPTIME,
> CHECK_USEDDISKSPACE,
> CHECK_SERVICESTATE,
> CHECK_PROCSTATE,
> CHECK_MEMUSE,
> CHECK_COUNTER,
> CHECK_FILEAGE
> };
>
> enum {
> MAX_VALUE_LIST = 30,
> PORT = 1248
> };
>
> char *server_address=NULL;
> char *volume_name=NULL;
> int server_port=PORT;
> char *value_list=NULL;
> char *req_password=NULL;
> unsigned long lvalue_list[MAX_VALUE_LIST];
> unsigned long warning_value=0L;
> unsigned long critical_value=0L;
> int check_warning_value=FALSE;
> int check_critical_value=FALSE;
> enum checkvars vars_to_check = CHECK_NONE;
> int show_all=FALSE;
>
> const char *progname = "check_nt";
>
> char recv_buffer[MAX_INPUT_BUFFER];
>
> void fetch_data (const char* address, int port, const char* sendb);
> int process_arguments(int, char **);
> void preparelist(char *string);
> int strtoularray(unsigned long *array, char *string, const char
> *delim);
> void print_help(void);
> void print_usage(void);
>
> int main(int argc, char **argv){
> int return_code = STATE_UNKNOWN;
> char *send_buffer=NULL;
> char *output_message=NULL;
> char *temp_string=NULL;
> char *description=NULL;
>
> double total_disk_space=0;
> double free_disk_space=0;
> double percent_used_space=0;
> double mem_commitLimit=0;
> double mem_commitByte=0;
> unsigned long utilization;
> unsigned long uptime;
> unsigned long age_in_minutes;
> double counter_value;
> int offset=0;
> int updays=0;
> int uphours=0;
> int upminutes=0;
>
> setlocale (LC_ALL, "");
> bindtextdomain (PACKAGE, LOCALEDIR);
> textdomain (PACKAGE);
>
> if(process_arguments(argc,argv)==ERROR)
> usage(_("Could not parse arguments\n"));
>
> /* initialize alarm signal handling */
> signal(SIGALRM,socket_timeout_alarm_handler);
>
> /* set socket timeout */
> alarm(socket_timeout);
>
> switch (vars_to_check) {
>
> case CHECK_CLIENTVERSION:
>
> asprintf(&send_buffer, "%s&1", req_password);
> fetch_data (server_address, server_port, send_buffer);
> if (value_list != NULL && strcmp(recv_buffer, value_list) != 0) {
> asprintf (&output_message, _("Wrong client version - running: %s,
> required: %s"), recv_buffer, value_list);
> return_code = STATE_WARNING;
> } else {
> asprintf (&output_message, "%s", recv_buffer);
> return_code = STATE_OK;
> }
> break;
>
> case CHECK_CPULOAD:
>
> if (value_list==NULL)
> output_message = strdup (_("missing -l parameters"));
> else if (strtoularray(lvalue_list,value_list,",")==FALSE)
> output_message = strdup (_("wrong -l parameter."));
> else {
> /* -l parameters is present with only integers */
> return_code=STATE_OK;
> temp_string = strdup (_("CPU Load"));
> /* loop until one of the parameters is wrong or not present */
> while (lvalue_list[0+offset]> (unsigned long)0 &&
> lvalue_list[0+offset]<=(unsigned long)17280 &&
> lvalue_list[1+offset]> (unsigned long)0 &&
> lvalue_list[1+offset]<=(unsigned long)100 &&
> lvalue_list[2+offset]> (unsigned long)0 &&
> lvalue_list[2+offset]<=(unsigned long)100) {
>
> /* Send request and retrieve data */
>
> asprintf(&send_buffer,"%s&2&%lu",req_password,lvalue_list[0+offset]);
> fetch_data (server_address, server_port, send_buffer);
>
> utilization=strtoul(recv_buffer,NULL,10);
>
> /* Check if any of the request is in a warning or critical state */
> if(utilization >= lvalue_list[2+offset])
> return_code=STATE_CRITICAL;
> else if(utilization >= lvalue_list[1+offset] &&
> return_code<STATE_WARNING)
> return_code=STATE_WARNING;
>
> asprintf(&output_message,_(" %lu%% (%lu min average)"),
> utilization, lvalue_list[0+offset]);
> asprintf(&temp_string,"%s%s",temp_string,output_message);
> offset+=3; /* move across the array */
> }
> if (strlen(temp_string)>10) /* we had at least one loop */
> output_message = strdup (temp_string);
> else
> output_message = strdup (_("not enough values for -l parameters"));
> }
> break;
>
> case CHECK_UPTIME:
>
> asprintf(&send_buffer, "%s&3", req_password);
> fetch_data (server_address, server_port, send_buffer);
> uptime=strtoul(recv_buffer,NULL,10);
> updays = uptime / 86400;
> uphours = (uptime % 86400) / 3600;
> upminutes = ((uptime % 86400) % 3600) / 60;
> asprintf(&output_message,_("System Uptime : %u day(s) %u hour(s) %u
> minute(s)"),updays,uphours, upminutes);
> return_code=STATE_OK;
> break;
>
> case CHECK_USEDDISKSPACE:
>
> if (value_list==NULL)
> output_message = strdup (_("missing -l parameters"));
> else if (strlen(value_list)!=1)
> output_message = strdup (_("wrong -l argument"));
> else {
> asprintf(&send_buffer,"%s&4&%s", req_password, value_list);
> fetch_data (server_address, server_port, send_buffer);
> free_disk_space=atof(strtok(recv_buffer,"&"));
> total_disk_space=atof(strtok(NULL,"&"));
> percent_used_space = ((total_disk_space - free_disk_space) /
> total_disk_space) * 100;
>
> if (free_disk_space>=0) {
> asprintf(&temp_string,_("%s:\\ - total: %.2f Gb - used: %.2f Gb
> (%.0f%%) - free %.2f Gb (%.0f%%)"),
> value_list, total_disk_space / 1073741824, (total_disk_space
> - free_disk_space) / 1073741824, percent_used_space,
> free_disk_space / 1073741824, (free_disk_space /
> total_disk_space)*100);
>
>
> if(check_critical_value==TRUE && percent_used_space >=
> critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && percent_used_space >=
> warning_value)
> return_code=STATE_WARNING;
> else
> return_code=STATE_OK;
>
> output_message = strdup (temp_string);
> }
> else {
> output_message = strdup (_("Free disk space : Invalid drive "));
> return_code=STATE_UNKNOWN;
> }
> }
> break;
>
> case CHECK_SERVICESTATE:
> case CHECK_PROCSTATE:
>
> if (value_list==NULL)
> output_message = strdup (_("No service/process specified"));
> else {
> preparelist(value_list); /* replace , between services with & to
> send the request */
> asprintf(&send_buffer,"%s&%u&%s&%s",
> req_password,(vars_to_check==CHECK_SERVICESTATE)?5:6,
> (show_all==TRUE)?_("ShowAll"):_("ShowFail"),value_list);
> fetch_data (server_address, server_port, send_buffer);
> return_code=atoi(strtok(recv_buffer,"&"));
> temp_string=strtok(NULL,"&");
> output_message = strdup (temp_string);
> }
> break;
>
> case CHECK_MEMUSE:
>
> asprintf(&send_buffer,"%s&7", req_password);
> fetch_data (server_address, server_port, send_buffer);
> mem_commitLimit=atof(strtok(recv_buffer,"&"));
> mem_commitByte=atof(strtok(NULL,"&"));
> percent_used_space = (mem_commitByte / mem_commitLimit) * 100;
> asprintf(&output_message,_("Memory usage: total:%.2f Mb - used: %.2f
> Mb (%.0f%%) - free: %.2f Mb (%.0f%%)"),
> mem_commitLimit / 1048576, mem_commitByte / 1048567,
> percent_used_space,
> (mem_commitLimit - mem_commitByte) / 1048576, (mem_commitLimit -
> mem_commitByte) / mem_commitLimit * 100);
>
> return_code=STATE_OK;
> if(check_critical_value==TRUE && percent_used_space >=
> critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && percent_used_space >=
> warning_value)
> return_code=STATE_WARNING;
>
> break;
>
> case CHECK_COUNTER:
>
> if (value_list==NULL)
> output_message = strdup (_("No counter specified"));
> else {
> preparelist(value_list); /* replace , between services with & to
> send the request */
> asprintf(&send_buffer,"%s&8&%s", req_password,value_list);
> fetch_data (server_address, server_port, send_buffer);
> strtok(value_list,"&"); /* burn the first parameters */
> description = strtok(NULL,"&");
> counter_value = atof(recv_buffer);
>
> if (description == NULL)
> asprintf(&output_message, "%.f", counter_value);
> else
> asprintf(&output_message,"%s = %.f", description, counter_value);
>
> if (critical_value > warning_value) { /* Normal thresholds */
> if(check_critical_value==TRUE && counter_value >= critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && counter_value >=
> warning_value)
> return_code=STATE_WARNING;
> else
> return_code=STATE_OK;
> }
> else { /* inverse thresholds
> */
> return_code=STATE_OK;
> if(check_critical_value==TRUE && counter_value <= critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && counter_value <=
> warning_value)
> return_code=STATE_WARNING;
> }
> }
> break;
>
> case CHECK_FILEAGE:
>
> if (value_list==NULL)
> output_message = strdup (_("No counter specified"));
> else {
> preparelist(value_list); /* replace , between services with & to
> send the request */
> asprintf(&send_buffer,"%s&9&%s", req_password,value_list);
> fetch_data (server_address, server_port, send_buffer);
> age_in_minutes = atoi(strtok(recv_buffer,"&"));
> description = strtok(NULL,"&");
> output_message = strdup (description);
>
> if (critical_value > warning_value) { /* Normal thresholds */
> if(check_critical_value==TRUE && age_in_minutes >= critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && age_in_minutes >=
> warning_value)
> return_code=STATE_WARNING;
> else
> return_code=STATE_OK;
> }
> else { /* inverse thresholds
> */
> if(check_critical_value==TRUE && age_in_minutes <= critical_value)
> return_code=STATE_CRITICAL;
> else if (check_warning_value==TRUE && age_in_minutes <=
> warning_value)
> return_code=STATE_WARNING;
> else
> return_code=STATE_OK;
> }
> }
> break;
>
> case CHECK_NONE:
> default:
> usage (_("Please specify a variable to check"));
> break;
>
> }
>
> /* reset timeout */
> alarm(0);
>
> printf("%s\n",output_message);
>
> return return_code;
> }
>
>
>
>
>
>
> /* process command-line arguments */
> int process_arguments(int argc, char **argv){
> int c;
>
> int option = 0;
> static struct option longopts[] =
> {
> {"port", required_argument,0,'p'},
> {"timeout", required_argument,0,'t'},
> {"critical", required_argument,0,'c'},
> {"warning", required_argument,0,'w'},
> {"variable", required_argument,0,'v'},
> {"hostname", required_argument,0,'H'},
> {"version", no_argument, 0,'V'},
> {"help", no_argument, 0,'h'},
> {0,0,0,0}
> };
>
> /* no options were supplied */
> if(argc<2) return ERROR;
>
> /* backwards compatibility */
> if (! is_option(argv[1])) {
> server_address = strdup(argv[1]);
> argv[1]=argv[0];
> argv=&argv[1];
> argc--;
> }
>
> for (c=1;c<argc;c++) {
> if(strcmp("-to",argv[c])==0)
> strcpy(argv[c],"-t");
> else if (strcmp("-wv",argv[c])==0)
> strcpy(argv[c],"-w");
> else if (strcmp("-cv",argv[c])==0)
> strcpy(argv[c],"-c");
> }
>
> while (1){
> c = getopt_long(argc,argv,"+hVH:t:c:w:p:v:l:s:d:",longopts,&option);
>
> if (c==-1||c==EOF||c==1)
> break;
>
> switch (c)
> {
> case '?': /* print short usage statement if args not parsable */
> printf("%s: Unknown argument: %s\n\n",progname,optarg);
> print_usage();
> exit(STATE_UNKNOWN);
> case 'h': /* help */
> print_help();
> exit(STATE_OK);
> case 'V': /* version */
> print_revision(progname,"$Revision: 1.21 $");
> exit(STATE_OK);
> case 'H': /* hostname */
> if (server_address) free(server_address);
> server_address = optarg;
> break;
> case 's': /* password */
> req_password = optarg;
> break;
> case 'p': /* port */
> if (is_intnonneg(optarg))
> server_port=atoi(optarg);
> else
> die(STATE_UNKNOWN,_("Server port an integer (seconds)\nType '%s
> -h' for additional help\n"),progname);
> break;
> case 'v':
> if(strlen(optarg)<4)
> return ERROR;
> if(!strcmp(optarg,"CLIENTVERSION"))
> vars_to_check=CHECK_CLIENTVERSION;
> else if(!strcmp(optarg,"CPULOAD"))
> vars_to_check=CHECK_CPULOAD;
> else if(!strcmp(optarg,"UPTIME"))
> vars_to_check=CHECK_UPTIME;
> else if(!strcmp(optarg,"USEDDISKSPACE"))
> vars_to_check=CHECK_USEDDISKSPACE;
> else if(!strcmp(optarg,"SERVICESTATE"))
> vars_to_check=CHECK_SERVICESTATE;
> else if(!strcmp(optarg,"PROCSTATE"))
> vars_to_check=CHECK_PROCSTATE;
> else if(!strcmp(optarg,"MEMUSE"))
> vars_to_check=CHECK_MEMUSE;
> else if(!strcmp(optarg,"COUNTER"))
> vars_to_check=CHECK_COUNTER;
> else if(!strcmp(optarg,"FILEAGE"))
> vars_to_check=CHECK_FILEAGE;
> else
> return ERROR;
> break;
> case 'l': /* value list */
> value_list = optarg;
> break;
> case 'w': /* warning threshold */
> warning_value=strtoul(optarg,NULL,10);
> check_warning_value=TRUE;
> break;
> case 'c': /* critical threshold */
> critical_value=strtoul(optarg,NULL,10);
> check_critical_value=TRUE;
> break;
> case 'd': /* Display select for services */
> if (!strcmp(optarg,"SHOWALL"))
> show_all = TRUE;
> break;
> case 't': /* timeout */
> socket_timeout=atoi(optarg);
> if(socket_timeout<=0)
> return ERROR;
> }
>
> }
>
> if (vars_to_check==CHECK_NONE)
> return ERROR;
>
> if (req_password == NULL)
> req_password = strdup (_("None"));
>
> return OK;
> }
>
>
>
>
>
>
> void fetch_data (const char *address, int port, const char *sendb) {
> int result;
>
> result=process_tcp_request(address, port, sendb,
> recv_buffer,sizeof(recv_buffer));
>
> if(result!=STATE_OK)
> die (result, "could not fetch information from server\n");
>
> if (!strncmp(recv_buffer,"ERROR",5))
> die (STATE_UNKNOWN, "NSClient - %s\n",recv_buffer);
> }
>
> int strtoularray(unsigned long *array, char *string, const char
> *delim) {
> /* split a <delim> delimited string into a long array */
> int idx=0;
> char *t1;
>
> for (idx=0;idx<MAX_VALUE_LIST;idx++)
> array[idx]=0;
>
> idx=0;
> for(t1 = strtok(string,delim);t1 != NULL; t1 = strtok(NULL, delim)) {
> if (is_numeric(t1) && idx<MAX_VALUE_LIST) {
> array[idx]=strtoul(t1,NULL,10);
> idx++;
> } else
> return FALSE;
> }
> return TRUE;
> }
>
> void preparelist(char *string) {
> /* Replace all , with & which is the delimiter for the request */
> int i;
>
> for (i = 0; (size_t)i < strlen(string); i++)
> if (string[i] == ',') {
> string[i]='&';
> }
> }
>
>
>
>
>
>
> void print_help(void)
> {
> print_revision(progname,"$Revision: 1.21 $");
> printf (_("\
> Copyright (c) 2000 Yves Rubin (rubiyz at yahoo.com)\n\n\
> This plugin collects data from the NSClient service running on a\n\
> Windows NT/2000/XP server.\n\n"));
> print_usage();
> printf (_("\nOptions:\n\
> -H, --hostname=HOST\n\
> Name of the host to check\n\
> -p, --port=INTEGER\n\
> Optional port number (default: %d)\n\
> -s <password>\n\
> Password needed for the request\n\
> -w, --warning=INTEGER\n\
> Threshold which will result in a warning status\n\
> -c, --critical=INTEGER\n\
> Threshold which will result in a critical status\n\
> -t, --timeout=INTEGER\n\
> Seconds before connection attempt times out (default: %d)\n\
> -h, --help\n\
> Print this help screen\n\
> -V, --version\n\
> Print version information\n"),
> PORT, DEFAULT_SOCKET_TIMEOUT);
> printf (_("\
> -v, --variable=STRING\n\
> Variable to check. Valid variables are:\n"));
> printf (_("\
> CLIENTVERSION = Get the NSClient version\n\
> If -l <version> is specified, will return warning if versions
> differ.\n"));
> printf (_("\
> CPULOAD = Average CPU load on last x minutes.\n\
> Request a -l parameter with the following syntax:\n\
> -l <minutes range>,<warning threshold>,<critical threshold>.\n\
> <minute range> should be less than 24*60.\n\
> Thresholds are percentage and up to 10 requests can be done in
> one shot.\n\
> ie: -l 60,90,95,120,90,95\n"));
> printf (_("\
> UPTIME = Get the uptime of the machine.\n\
> No specific parameters. No warning or critical threshold\n"));
> printf (_("\
> USEDDISKSPACE = Size and percentage of disk use.\n\
> Request a -l parameter containing the drive letter only.\n\
> Warning and critical thresholds can be specified with -w and
> -c.\n"));
> printf (_("\
> MEMUSE = Memory use.\n\
> Warning and critical thresholds can be specified with -w and
> -c.\n"));
> printf (_("\
> SERVICESTATE = Check the state of one or several services.\n\
> Request a -l parameters with the following syntax:\n\
> -l <service1>,<service2>,<service3>,...\n\
> You can specify -d SHOWALL in case you want to see working
> services\n\
> in the returned string.\n"));
> printf (_("\
> PROCSTATE = Check if one or several process are running.\n\
> Same syntax as SERVICESTATE.\n"));
> printf (_("\
> COUNTER = Check any performance counter of Windows NT/2000.\n\
> Request a -l parameters with the following syntax:\n\
> -l \"\\\\<performance object>\\\\counter\",\"<description>\n\
> The <description> parameter is optional and \n\
> is given to a printf output command which require a float
> parameters.\n\
> Some examples:\n\
> \"Paging file usage is %%.2f %%%%\"\n\
> \"%%.f %%%% paging file used.\"\n"));
> printf (_("Notes:\n\
> - The NSClient service should be running on the server to get any
> information\n\
> (http://nsclient.ready2run.nl).\n\
> - Critical thresholds should be lower than warning thresholds\n"));
> }
>
>
>
>
> void print_usage(void)
> {
> printf(_("\
> Usage: %s -H host -v variable [-p port] [-w warning] [-c critical]\
> [-l params] [-d SHOWALL] [-t timeout]\n"), progname);
> printf (_(UT_HLP_VRS), progname, progname);
> }
More information about the Devel
mailing list