[Nagiosplug-devel] [ nagiosplug-Patches-921467 ] fping rta in ms

[SourceForge.net]

Patches item #921467, was opened at 2004-03-22 16:10
Message generated for change (Comment added) made by mattkent
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=921467&group_id=29880

Category: Bugfix
Group: None
>Status: Open
Resolution: Fixed
Priority: 5
Submitted By: Matthew Kent (mattkent)
Assigned to: Karl DeBisschop (kdebisschop)
Summary: fping rta in ms

Initial Comment:
fping's help claims to take the critical and warn rta
values in milliseconds like ping, but as we can see it
doesn't. 

# ./check_fping -H pdc-pv1.pv -w 10,10% -c 100,25%
FPING OK - pdc-pv1.pv (loss=0%, rta=42.800000
ms)|loss=0%;10;25;0;100 rta=42799us;10000000;100000000;0
# ./check_ping -H pdc-pv1.pv -w 10,10% -c 100,25%
PING WARNING - Packet loss = 0%, RTA = 32.67 ms

As they always stay in 'OK' state, this sucks for
anyone like me who replaced the ping checks with fping
and didn't test the result  :)

Tiny patch against version in cvs fixes the inconsistency.

----------------------------------------------------------------------

>Comment By: Matthew Kent (mattkent)
Date: 2004-03-23 12:21

Message:
Logged In: YES 
user_id=983566

I suppose actually attaching the diff might have helped :)
but you fixed the same 2 lines.

Thanks

----------------------------------------------------------------------

Comment By: Karl DeBisschop (kdebisschop)
Date: 2004-03-22 22:47

Message:
Logged In: YES 
user_id=1671

np patch supplied, but I confirmed the bug and fixed in CVS
as best as I can tell.

Thanks for finding this, lets us know if I goofed the fix.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=921467&group_id=29880