[Nagiosplug-devel] netutils.c / check_udp

Jason Martin jhmartin at toger.us
Fri Feb 13 13:54:21 CET 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've noticed that several of the 'core' plugins call functions within
netutils.c, such as check_udp. It seems that netutils.c does printf's if
it encounters any sort of errors. However, plugins (such as check_udp)  
also do printf's with status data based on the return code of the
netutils.c function.  This means that Nagios will never see the more
user-friendly message generated by check_udp since it is on the second
line.

Is this desirable, or would it be better to have netutils put the
diagnostic messages into a buffer and make it available to the calling
function, or perhaps put it behind a "if (verbose)"?  Otherwise the other
'core' network-based plugins should probably have the extra messages
removed for cleanliness.

- -Jason Martin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.3.3 (GNU/Linux)
Comment: pgpenvelope 2.10.2 - http://pgpenvelope.sourceforge.net/

iD8DBQFALUaOl2ODWuqVSBMRAj2WAJ9MRVa8BJGHmUP4tC2CnN522/dcVwCgl0y/
2//leYQZC9MkoyaIivFZxRg=
=oc6j
-----END PGP SIGNATURE-----




More information about the Devel mailing list