[Nagiosplug-devel] [ nagiosplug-Bugs-1078682 ] broken in CVS - check_ping, _http, and more..

[SourceForge.net]

Bugs item #1078682, was opened at 2004-12-04 00:17
Message generated for change (Settings changed) made by opensides
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1078682&group_id=29880

Category: Argument proccessing
Group: CVS
>Status: Closed
>Resolution: Fixed
Priority: 7
Submitted By: John Sivak (jsivak)
Assigned to: Benoit Mortier (opensides)
Summary: broken in CVS - check_ping, _http, and more..

Initial Comment:
This is related to 
https://sourceforge.net/tracker/index.php?func=detail&aid=1077590&group_id=29880&atid=397599
which was "fixed".

But, the fix didn't change the "return OK;" statement
in either process_arguments() or validate_arugments()
in the following files:
check_ping.c
check_http.c
check_dns.c
check_smtp.c
check_mysql.c
check_tcp.c

OK is defined as "0" in common.h, so the "if
(process_arguments (argc, argv) != TRUE)" checks are
failing when OK is returned (0 != TRUE).

I didn't supply a patch since I'm not sure how you want
to fix the problem (either changing the "if" statement
or changing the return statements..)

----------------------------------------------------------------------

Comment By: John Sivak (jsivak)
Date: 2004-12-04 16:42

Message:
Logged In: YES 
user_id=679094

Much better.

Thanx!

----------------------------------------------------------------------

Comment By: Benoit Mortier (opensides)
Date: 2004-12-04 00:56

Message:
Logged In: YES 
user_id=388184

Hi, 
 
i just fixed it in cvs, reverting my changes from !=TRUE to == ERROR 
could you please test the fix. 
 
Thank you 

----------------------------------------------------------------------

Comment By: Benoit Mortier (opensides)
Date: 2004-12-04 00:28

Message:
Logged In: YES 
user_id=388184

 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1078682&group_id=29880