[Nagiosplug-devel] Performance patches (was [ nagiosplug-Patches-740404 ] 1.3.0 perf ormance addon for disk/http/load/ping/procs/swap/u)

[Voon, Ton]

Copying to nagiosplug-devel. Please remove nagios-devel if replying. (Sorry,
I originally sent to wrong group.)

Based on patches received and Karl's replies, I think perf data should
have/be:

- short labels
- generic and common labels across plugins if possible
- comma separated, no spaces. Regex format: [a-z0-9]+=[0-9]?\.?[0-9]+
- redundant data removed (eg, if check_disk returns pct and number (used),
can calculate free bytes)

My suggestion for labels are:

Name ; Units ; printf format ; Details
time ; seconds ; %.3f ; time taken to do a specific check (eg DNS query,
HTTP request, ping RTA)
pct ; percent ; %.3f ; percentage (used rather than free if applicable) (eg
total disk, total swap, ping percent loss)
number ; must be bytes if applicable ; %d ; a given number of things (used
rather than free if applicable) (eg processes, users, bytes used such as
total disk or total swap)
numberf ; float ; %.3f ; a given number of things that may be fractional
(eg, load average, average bytes transmitted)
counter ; a continuous counter (must be bytes if applicable) ; %d ; a
continuous counter (eg bytes transmitted on an interface)
load1 ; load ; %.2f ; load average over 1 min
load5 ; load ; %.2f ; load average over 5 min
load15 ; load ; %.2f ; load average over 15 min

Note loadx - not really keen on these, but don't seem to fit into any other
labels, unless we only return load5 and use numberf.

Maybe number should be a float so that numberf is not required?

Note that the patches submitted for check_ping had perf labels of rta and
loss, but I think these should be time and pct respectively. I think this
makes it easier for something like RRD to work out what type of value it is
to draw the graphs. Why the returned values are bad is then up to
interpretation (and that is the key to any performance analysis!).

Maybe this is too reductionalism and the labels should describe the measure,
but I think the labels should be generic and the plugin gives the context.

I agree, only in HEAD. 

Comments?

Ton

> -----Original Message-----
> From:	Subhendu Ghosh [SMTP:sghosh at sghosh.org]
> Sent:	Thursday, May 22, 2003 2:08 PM
> To:	Voon, Ton
> Cc:	nagios-devel at lists.sourceforge.net
> Subject:	Re: [Nagios-devel] FW: [Nagiosplug-devel] [
> nagiosplug-Patches-740404 ] 1.3.0 perfor mance addon for
> disk/http/load/ping/procs/swap/u
> 
> perf patches should go into HEAD only.
> 
> is there a list of labels that that has been agreed on?
> 
> -sg
> 
> On Tue, 20 May 2003, Voon, Ton wrote:
> 
> > What's the policy on performance patches? Edwin's patches look useful,
> but I
> > seem to remember some discussion about sticking to similar labels
> between
> > plugins. Has any decision been made? Is this for r1_3_0 or for HEAD
> only?
> > 
> > I suggest that developer-guidelines.sgml be updated to include all
> labels so
> > that they can be reused. I'm happy to update after guidance ;-)
> > 
> > Ton
> > 
> > > -----Original Message-----
> > > From:	SourceForge.net [SMTP:noreply at sourceforge.net]
> > > Sent:	Tuesday, May 20, 2003 1:14 PM
> > > To:	noreply at sourceforge.net
> > > Subject:	[Nagiosplug-devel] [ nagiosplug-Patches-740404 ] 1.3.0
> > > performance addon for disk/http/load/ping/procs/swap/u
> > > 
> > > Patches item #740404, was opened at 2003-05-20 12:14
> > > Message generated for change (Tracker Item Submitted) made by Item
> > > Submitter
> > > You can respond by visiting: 
> > >
> https://sourceforge.net/tracker/?func=detail&atid=397599&aid=740404&group_
> > > id=29880
> > > 
> > > Category: Perf data
> > > Group: None
> > > Status: Open
> > > Resolution: None
> > > Priority: 5
> > > Submitted By: Edwin Eefting (drpsycho)
> > > Assigned to: Nobody/Anonymous (nobody)
> > > Summary: 1.3.0 performance addon for disk/http/load/ping/procs/swap/u
> > > 
> > > Initial Comment:
> > > These contain the new performance patches for 1.3.0.
> > > This way the plugins will return the extra performance data that is
> > > neccesary to make nice graphs with rrd for example. (contact me for
> the
> > > addons for this)
> > > 
> > > developers: please implement this, as i'm seeing people using the most
> > > wicked ways to get performance data now. (e.g. parsing the default
> plugin
> > > output!)
> > > 
> > 
> > 
> > This private and confidential e-mail has been sent to you by Egg.
> > The Egg group of companies includes Egg Banking plc
> > (registered no. 2999842), Egg Financial Products Ltd (registered
> > no. 3319027) and Egg Investments Ltd (registered no. 3403963) which
> > carries out investment business on behalf of Egg and is regulated
> > by the Financial Services Authority.  
> > Registered in England and Wales. Registered offices: 1 Waterhouse
> Square,
> > 138-142 Holborn, London EC1N 2NA.
> > If you are not the intended recipient of this e-mail and have
> > received it in error, please notify the sender by replying with
> > 'received in error' as the subject and then delete it from your
> > mailbox.
> > 
> > 
> > 
> > -------------------------------------------------------
> > This SF.net email is sponsored by: ObjectStore.
> > If flattening out C++ or Java code to make your application fit in a
> > relational database is painful, don't do it! Check out ObjectStore.
> > Now part of Progress Software. http://www.objectstore.net/sourceforge
> > _______________________________________________
> > Nagios-devel mailing list
> > Nagios-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/nagios-devel
> > 
> 
> -- 
> 
>