[Nagiosplug-devel] The various plugins/*.h.in files

[Jeremy T. Bouse]

	I've been looking at the build process and really puzzled why
we even need all of these... Doing a build I can't see much changes in
any of them at all with the exception of netutils.h.in and I'm looking
into whether even that is needed... I get the following diffs:

--- common.h.in 2003-03-10 09:17:52.000000000 -0800
+++ common.h    2003-03-12 14:33:01.000000000 -0800
@@ -1,3 +1,4 @@
+/* plugins/common.h.  Generated automatically by configure.  */

/******************************************************************************
  *
  * Nagios plugins common include file

--- popen.h.in  2002-10-15 21:57:34.000000000 -0700
+++ popen.h     2003-03-12 14:33:02.000000000 -0800
@@ -1,3 +1,4 @@
+/* plugins/popen.h.  Generated automatically by configure.  */
 FILE *spopen (const char *);
 int spclose (FILE *);
 RETSIGTYPE popen_timeout_alarm_handler (int);

--- utils.h.in  2003-03-12 09:03:11.000000000 -0800
+++ utils.h     2003-03-12 14:33:02.000000000 -0800
@@ -1,3 +1,4 @@
+/* plugins/utils.h.  Generated automatically by configure.  */
 /* header file for nagios plugins utils.c */

 /* this file should be included in all plugins */

--- version.h.in        2002-11-13 18:26:34.000000000 -0800
+++ version.h   2003-03-12 14:33:01.000000000 -0800
@@ -1 +1,2 @@
+/* plugins/version.h.  Generated automatically by configure.  */
 #define CVS_DATE "$Date: 2002/11/14 02:26:34 $"

--- netutils.h.in       2003-03-07 18:36:53.000000000 -0800
+++ netutils.h  2003-03-12 14:33:02.000000000 -0800
@@ -1,3 +1,4 @@
+/* plugins/netutils.h.  Generated automatically by configure.  */

/******************************************************************************
 *
 * Nagios plugins net utilities include file
@@ -30,9 +31,9 @@
 *

******************************************************************************/

-#undef STDC_HEADERS
-#undef HAVE_STRINGS_H
-#undef HAVE_STRING_H
+#define STDC_HEADERS 1
+#define HAVE_STRINGS_H 1
+#define HAVE_STRING_H 1

 #include "config.h"
 #include "common.h"

	As you can see there isn't any change other than a comment line
added by configure for common.h, popen.h, utils.h and version.h so is it
really necessary to run them through the entire generation process? And
the lines in netutils.h that are changed are pick'd up anyway by it's
inclusion of config.h so these defines are only duplicating things...

	I also don't see anywhere that the CVS_DATE defined in
version.h is ever used so is there a reason to keep it at all now? I'm
gonna do some tests locally while I wait for some feedback... I'll
report back my findings...

	Jeremy