[Nagiosplug-devel] check_disk.c HEAD without -d parameters

[Karl DeBisschop]

On Fri, 2003-06-27 at 07:46, Voon, Ton wrote:
> I don't understand the /dev/???? argument. Why would you specify a file to
> check? I know a "df /dev/file" will return information for the /dev
> filesystem, but check_disk doesn't try to work out which filesystem a file
> belongs to, so currently "check_disk -p /dev/file" returns a disk not found.
> I think check_disk should only check disks/partitions/filesystems and not
> individual files.

You say check_disk does not try to work out which filesystem a file
belongs to -- I assert that it should. 

But you raise good points. I have to run now, but lets keep this
question open for a bit.

> I guess there could be confusion if there was a device called /var and a
> filesystem called /var, but this would never be the case as they would be
> unique locations under /.

> However, I agree a Nagios administrator should know the difference. If -d is
> to be used, I think it should be done for the 1.4 release as we are already
> breaking current syntax (eg, -p "/ /var" no longer works - must be -p / -p
> /var)

Yes - I recognize that it is a change and I do not propose back-porting
to 1.3.x

> 
> > -----Original Message-----
> > From:	Karl DeBisschop [SMTP:karl at debisschop.net]
> > Sent:	Friday, June 27, 2003 12:26 PM
> > To:	Ton Voon
> > Cc:	nagiosplug-devel at lists.sourceforge.net
> > Subject:	Re: [Nagiosplug-devel] check_disk.c HEAD without -d
> > parameters
> > 
> > On Wed, 2003-06-25 at 09:58, Voon, Ton wrote:
> > > Just wanted to see what the consensus was on this change. v1.23 wanted:
> > > 
> > > check_disk -d /dev/dsk/c0t0d0s5
> > > 
> > > in order to test a physical partition. The change below removes this so
> > that
> > > you can use:
> > > 
> > > check_disk -p /dev/dsk/c0t0d0s5
> > > 
> > > as you would have done in the r1_3_0 version of check_disk. I didn't
> > think
> > > there was a need to use a separate flag to specify devices.
> > > 
> > > Any thoughts? I can backout if people think -d is better.
> > 
> > On issue is that if you specify a -p /dev/???? you actually are
> > specifying a file on the /dev partition. What if the goal is to check
> > the number of inodes used on /dev? You make it impossible (or difficult
> > to do so).
> > 
> > I personally think he convenience of being able to willfully confuse
> > devices and filesystems is minor. If may be appropriate for a
> > user-oriented utility like df, but I think a nagios adminsistrator
> > should be able to tell the difference. 
> > 
> > I have a vague sense that I had other reasons at the time, But those
> > elude me at the moment.
> > 
> > I'd prefer it be backed out.
> > --
> > Karl
> 
> 
> This private and confidential e-mail has been sent to you by Egg.
> The Egg group of companies includes Egg Banking plc
> (registered no. 2999842), Egg Financial Products Ltd (registered
> no. 3319027) and Egg Investments Ltd (registered no. 3403963) which
> carries out investment business on behalf of Egg and is regulated
> by the Financial Services Authority.  
> Registered in England and Wales. Registered offices: 1 Waterhouse Square,
> 138-142 Holborn, London EC1N 2NA.
> If you are not the intended recipient of this e-mail and have
> received it in error, please notify the sender by replying with
> 'received in error' as the subject and then delete it from your
> mailbox.