[Nagiosplug-devel] check_dns.c: Requires DNS server (patch)

Steve Bonds r1p6os402 at sneakemail.com
Tue Feb 4 16:29:03 CET 2003


The help text for the check_dns.c plugin says that the DNS server is
optional, yet the program logic found on line 366 of the current CVS
version requires the server to be specified.

----
if (dns_server[0] == 0) {
	if (is_host (argv[c]) == FALSE) {
		printf ("Invalid name/address: %s\n\n", argv[c]);
		return ERROR;
	}
-----

(If unspecified, dns_server is null at that point, triggering an "Invalid
name/address".  It's better than the last beta version at least, as that
one coredumps on me from utils.c.  ;-)

The attached patch corrects the documentation so that it says the server
is required.

  -- Steve





More information about the Devel mailing list